refactor: remove legacy backward-compatibility code from CLI and geotrack

- Remove duplicate platform_id/platform_name/platform_type fields from campaign create
  (only the platforms array is now written)
- Remove legacy platform_id fallback display in campaign show/list/delete/inspect
- Remove deprecated --upload CLI option from geotrack convert, multibeam, and adcp
- Remove upload parameter from geotrack processor convert() function
- Update test mock metadata to use platforms array format

Author: beatfactor

oceanstream/cli.py

@@ -379,12 +379,6 @@ def create_campaign_command(
         if platforms_list:
             # From --platform CLI option(s)
             metadata['platforms'] = platforms_list
-            # Also set legacy fields for backward compatibility (first platform)
-            metadata['platform_id'] = platforms_list[0]['id']
-            if 'name' in platforms_list[0]:
-                metadata['platform_name'] = platforms_list[0]['name']
-            if 'type' in platforms_list[0]:
-                metadata['platform_type'] = platforms_list[0]['type']
         elif platform_id:
             # From interactive mode - convert to platforms array
             platform_dict = {"id": platform_id}
@@ -393,12 +387,6 @@ def create_campaign_command(
             if platform_type:
                 platform_dict["type"] = platform_type
             metadata['platforms'] = [platform_dict]
-            # Also set legacy fields
-            metadata['platform_id'] = platform_id
-            if platform_name:
-                metadata['platform_name'] = platform_name
-            if platform_type:
-                metadata['platform_type'] = platform_type
 
         # Remove None values
         metadata = {k: v for k, v in metadata.items() if v is not None}
@@ -475,13 +463,6 @@ def show_campaign_command(
                             typer.echo(f"      Type: {p['type']}")
                         if 'row_count' in p:
                             typer.echo(f"      Rows: {p['row_count']:,}")
-            # Legacy single-platform fields (backward compatibility)
-            elif "platform_id" in metadata:
-                typer.echo(f"Platform ID:        {metadata['platform_id']}")
-                if "platform_name" in metadata:
-                    typer.echo(f"Platform Name:      {metadata['platform_name']}")
-                if "platform_type" in metadata:
-                    typer.echo(f"Platform Type:      {metadata['platform_type']}")
 
             typer.echo()
 
@@ -585,15 +566,12 @@ def list_campaigns_command(
                     campaign_id = campaign.get("campaign_id", "unknown")
                     typer.echo(f"{i}. {campaign_id}")
 
-                    # Show platforms (new format) or legacy platform_id
                     if "platforms" in campaign and campaign["platforms"]:
                         platforms = campaign["platforms"]
                         if len(platforms) == 1:
                             typer.echo(f"   Platform:     {platforms[0].get('id', 'N/A')}")
                         else:
                             typer.echo(f"   Platforms:    {len(platforms)} ({', '.join(p.get('id', '?') for p in platforms)})")
-                    elif "platform_id" in campaign:
-                        typer.echo(f"   Platform:     {campaign['platform_id']}")
 
                     if "description" in campaign:
                         desc = campaign['description']
@@ -623,7 +601,7 @@ def list_campaigns_command(
                         else:
                             platform_str = f"{len(platforms)} platforms"
                     else:
-                        platform_str = campaign.get("platform_id", "N/A")
+                        platform_str = "N/A"
 
                     description = campaign.get("description", "")
 
@@ -670,15 +648,12 @@ def delete_campaign_command(
             if not yes:
                 typer.echo(f"[campaign delete] About to delete campaign: {campaign_id}")
 
-                # Show platforms (new format) or legacy platform_id
                 if "platforms" in metadata and metadata["platforms"]:
                     platforms = metadata["platforms"]
                     if len(platforms) == 1:
                         typer.echo(f"[campaign delete]   Platform: {platforms[0].get('id', 'N/A')}")
                     else:
                         typer.echo(f"[campaign delete]   Platforms: {len(platforms)} ({', '.join(p.get('id', '?') for p in platforms)})")
-                elif "platform_id" in metadata:
-                    typer.echo(f"[campaign delete]   Platform: {metadata['platform_id']}")
 
                 if "description" in metadata:
                     typer.echo(f"[campaign delete]   Description: {metadata['description']}")
@@ -742,7 +717,6 @@ def inspect_campaign_command(
             typer.echo(f"{'=' * 70}")
 
             if metadata:
-                # Show platforms (new format) or legacy platform_id
                 if "platforms" in metadata and metadata["platforms"]:
                     platforms = metadata["platforms"]
                     if len(platforms) == 1:
@@ -752,8 +726,6 @@ def inspect_campaign_command(
                         for p in platforms:
                             row_info = f" ({p['row_count']:,} rows)" if 'row_count' in p else ""
                             typer.echo(f"  - {p.get('id', 'unknown')}{row_info}")
-                elif "platform_id" in metadata:
-                    typer.echo(f"Platform:         {metadata['platform_id']}")
                 if "description" in metadata:
                     desc = metadata['description']
                     if len(desc) > 60:
@@ -885,7 +857,6 @@ def convert_command(
             help="Output path for GeoParquet. Local path or cloud URI (az://container/path, s3://bucket/path). Campaign subdirectories are auto-created.",
         ),
         provider: str = typer.Option(None, "--provider", help="Data provider type (overrides global --provider setting). Available: saildrone, r2r."),
-        upload: bool = typer.Option(False, "--upload", help="(Deprecated) Use --use-cloud-storage instead."),
         use_cloud_storage: bool = typer.Option(False, "--use-cloud-storage", help="Write output to configured cloud storage (requires 'oceanstream storage add' first)."),
         verbose: bool = typer.Option(False, "-v", help="Emit detailed progress information."),
         list_columns: bool = typer.Option(False, help="List available columns from the input CSVs and exit."),
@@ -965,7 +936,6 @@ def convert_command(
                 print_schema=print_schema,
                 provider_metadata=provider_metadata,
                 dry_run=dry_run,
-                upload=upload,
                 yes=yes,
                 generate_pmtiles=generate_pmtiles,
                 pmtiles_minzoom=pmtiles_minzoom,
@@ -2037,7 +2007,6 @@ def multibeam_command(
         input_dir: Path = typer.Option(Path("raw_multibeam"), exists=True, file_okay=False, help="Directory with raw multibeam backscatter data."),
         output_dir: Path = typer.Option(Path("out/multibeam"), help="Output directory for processed multibeam products."),
         verbose: bool = typer.Option(False, "-v", help="Emit progress information."),
-        upload: bool = typer.Option(False, help="Upload processed data to cloud storage after conversion (future)."),
         dry_run: bool = typer.Option(False, "--dry-run", help="Show planned actions without executing."),
     ) -> None:
         global _provider_obj
@@ -2063,7 +2032,6 @@ def adcp_command(
         input_dir: Path = typer.Option(Path("raw_adcp"), exists=True, file_okay=False, help="Directory with raw ADCP data."),
         output_dir: Path = typer.Option(Path("out/adcp"), help="Output directory for processed ADCP products."),
         verbose: bool = typer.Option(False, "-v", help="Emit progress information."),
-        upload: bool = typer.Option(False, help="Upload processed data to cloud storage after conversion (future)."),
         dry_run: bool = typer.Option(False, "--dry-run", help="Show planned actions without executing."),
     ) -> None:
         global _provider_obj

oceanstream/geotrack/processor.py

@@ -1556,7 +1556,6 @@ def convert(
     print_schema: bool = False,
     provider_metadata: bool = False,
     dry_run: bool = False,
-    upload: bool = False,
     yes: bool = False,
     generate_pmtiles: bool = False,
     pmtiles_minzoom: int = 0,
@@ -1601,7 +1600,6 @@ def convert(
         print_schema: Print GeoParquet schema and exit
         provider_metadata: Print provider metadata and exit
         dry_run: Analyze inputs without writing files
-        upload: (Deprecated) Use use_cloud_storage instead
         yes: Skip confirmation prompts
         generate_pmtiles: Generate PMTiles vector tiles with segments, day markers, and arrows
         pmtiles_minzoom: Minimum zoom level for PMTiles (0-15)
@@ -1648,11 +1646,11 @@ def convert(
     output_str = str(output_dir)
     is_cloud_uri = output_str.startswith(("az://", "abfs://", "s3://", "gs://"))
 
-    if is_cloud_uri or use_cloud_storage or upload:
+    if is_cloud_uri or use_cloud_storage:
         try:
             storage_path = resolve_output_path(
                 output_dir,
-                use_active_storage=(use_cloud_storage or upload) and not is_cloud_uri,
+                use_active_storage=use_cloud_storage and not is_cloud_uri,
             )
             filesystem = storage_path.filesystem
             resolved_output_dir = storage_path.path
@@ -1778,7 +1776,6 @@ def convert(
                     print_schema=print_schema,
                     provider_metadata=provider_metadata,
                     dry_run=dry_run,
-                    upload=upload,
                     yes=True,  # Skip confirmation prompts in recursive calls
                     generate_pmtiles=generate_pmtiles,
                     pmtiles_minzoom=pmtiles_minzoom,

oceanstream/tests/unit/test_cli_commands.py

@@ -178,8 +178,7 @@ def test_show_campaign_success(self):
         """Test showing campaign details."""
         mock_metadata = {
             'campaign_id': 'FK161229',
-            'platform_id': 'R/V_Falkor',
-            'platform_name': 'Research Vessel Falkor',
+            'platforms': [{'id': 'R/V_Falkor', 'name': 'Research Vessel Falkor'}],
             'description': 'Test campaign',
             'start_date': '2016-12-29',
             'end_date': '2017-01-20',
@@ -211,12 +210,12 @@ def test_list_campaigns_with_results(self):
         mock_campaigns = [
             {
                 'campaign_id': 'FK161229',
-                'platform_id': 'R/V_Falkor',
+                'platforms': [{'id': 'R/V_Falkor'}],
                 'start_date': '2016-12-29',
             },
             {
                 'campaign_id': 'SD1030_2023',
-                'platform_id': 'sd1030',
+                'platforms': [{'id': 'sd1030'}],
                 'start_date': '2023-06-01',
             },
         ]
@@ -242,7 +241,7 @@ def test_list_campaigns_verbose(self):
         mock_campaigns = [
             {
                 'campaign_id': 'FK161229',
-                'platform_id': 'R/V_Falkor',
+                'platforms': [{'id': 'R/V_Falkor'}],
                 'description': 'Test campaign',
                 'start_date': '2016-12-29',
                 'end_date': '2017-01-20',
@@ -262,7 +261,7 @@ class TestDeleteCampaignCommand:
 
     def test_delete_campaign_success_with_yes_flag(self):
         """Test deleting campaign with --yes flag."""
-        mock_metadata = {'campaign_id': 'FK161229', 'platform_id': 'R/V_Falkor'}
+        mock_metadata = {'campaign_id': 'FK161229', 'platforms': [{'id': 'R/V_Falkor'}]}
 
         with patch('oceanstream.geotrack.campaign.load_campaign_metadata', return_value=mock_metadata):
             with patch('oceanstream.geotrack.campaign.delete_campaign') as mock_delete: