Get rid of some deprecations - #373
Open
jacopotediosi wants to merge 2 commits into
Open
Conversation
This has been performed by using the command `octoprint dev plugin:migrate-to-pyproject`. Ref: https://docs.octoprint.org/en/main/plugins/pyproject_toml_migration.html
Member
Author
|
@benlye When you have time, could you please take a look at this one? |
1 similar comment
Member
Author
|
@benlye When you have time, could you please take a look at this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm an active contributor to OctoPrint core. I helped ship OctoPrint 2.0.0rc1 and I'm now helping plugins stay compatible with the new and upcoming OctoPrint releases, which is why you're receiving this PR.
This PR fixes the use of some deprecations that were causing warnings in OctoPrint's logs.
In particular:
octoprint dev plugin:migrate-to-pyprojectcommand, with minor manual adjustments to the generated files.|safefilter to templates that injected HTML code inside Jinja variables.I tested the installation on both OctoPrint 2.0.0rc1 and the latest stable release 1.11.7 and didn't notice any significant issues.