Added plugin WaveshareUPS

[michaelszubartowicz]

This plugin adds a navbar icon to read out the Waveshare UPS HAT.

[jneilliii]

just a couple of small adjustments. please update the date and in your plugin, you need to add daemon=True to your Thread here. If you don't do this, when you try to restart/shutdown OctoPrint it can get in the way of the process.

[jneilliii]

curious also, @michaelszubartowicz if you need to add any instructions for enabling I2C, etc. from the system level?

[michaelszubartowicz]

curious also, @michaelszubartowicz if you need to add any instructions for enabling I2C, etc. from the system level?

Yes, you are right. I have added this requirement to the readme as well as the md-file of this pull request.

[jneilliii]

Your tagged release needs to match the version number in setup.py. setup.py is showing 0.1.1 but your release tag is V1.0-rc2.

[michaelszubartowicz]

Your tagged release needs to match the version number in setup.py. setup.py is showing 0.1.1 but your release tag is V1.0-rc2.

that was a typo, thanks for pointing it out, new tag is now V0.1-rc3

[michaelszubartowicz]

@jneilliii no pressure, but is there anything else I can do before this merge request can go through?

[jneilliii]

It's still wrong.

The tag should match the release version in setup.py, which is still showing 0.1.1.

https://github.com/michaelszubartowicz/OctoPrint-WaveshareUPS/blob/main/setup.py#L17

So, delete the release, create a new release with tag 0.1.1 and we should be ready to go. Future updates on the plugin should follow that same strategy for the update hook to function properly.

[michaelszubartowicz]

It's still wrong.

The tag should match the release version in setup.py, which is still showing 0.1.1.

https://github.com/michaelszubartowicz/OctoPrint-WaveshareUPS/blob/main/setup.py#L17

So, delete the release, create a new release with tag 0.1.1 and we should be ready to go. Future updates on the plugin should follow that same strategy for the update hook to function properly.

Thank you for this clarification, I did not know how the update hook works. I did as suggested, the new release is now V0.1.1