Release Camera Streamer Prusa Connect Uploader#1369
Release Camera Streamer Prusa Connect Uploader#1369rizz360 wants to merge 2 commits intoOctoPrint:gh-pagesfrom
Conversation
There was a problem hiding this comment.
Your plugin should probably use more modern methods of getting the snapshot url here. Accessing this settings path is going to be deprecated in the future I think. You could use octoprint.webcam.get_default_webcam() I think, but would have to experiment a bit to validate.
What's the logic behind having the snapshots uploaded all the time versus just while printing?
Your threading timer here should also have the daemon set to true prior to starting, something like this.
def start_upload_loop(self):
interval = self._settings.get_int(["upload_interval"])
self.timer = threading.Timer(interval, self.upload_loop)
self.timer.daemon = True
self.timer.start()
Finally, as mentioned in the code comment below about archive url, you should add a software update hook so your plugin can detect when and how to update. You can find more details here in the docs, and a quick example is provided there just make sure to replace updateplugindemo to prusa_connect_uploader in the return.
|
Hi @jneilliii , I’ve updated the plugin to:
Thanks for your feedback—please let me know if anything else is needed! |
|
Thanks for these changes, I only have one other change now before accepting this PR. Instead of self._logger.info at this line with every image upload, you should make that self._logger.debug to avoid spamming octoprint.log every 10 seconds by default. |
Not really a deal breaker, but I'm also not seeing this implemented. |
Also not seeing this implemented on the requests. |
Hi everyone, I recently spoke with foosel, the maintainer of OctoPrint, about the new webcam integration, and I thought it would be helpful to share what I learned — especially since I noticed you're running into the same issue I initially did. It's not obvious at first (it certainly wasn't to me until it was explained), but the main purpose of the Your plugin does work when using URLs from the Compatibility Layer ( Going forward, keep in mind that the correct way to capture snapshots is to use the built-in |
|
I assume that method also requires the knowledge of the configured webcam plugins and which one is active, so you'd have to iterate over get_webcam_configurations to find the active name. |
Sorry about that! I quickly generated the reply using AI based on the git diff and it completely made that up. |
Thanks, I'll look into that! |
You should be aware that we now require plugin developers to tell us if they used any AI tool to code the plugin, and also added the following to the "Registering a new plugin" page:
|
Thanks for the heads up! In that case I'm retiring the pull request. The main motivation was for anyone that's interested to be able to easily install it. |
Hi! This is my first OctoPrint plugin submission.
Prusa Connect Uploader is a simple plugin that captures webcam snapshots from OctoPrint and uploads them to Prusa Connect, making it easier to monitor ongoing prints remotely through Prusa’s interface.
It allows users to:
I've followed the plugin metadata format and included the required fields (including archive, python, cloud attribute, etc.). I hope I did everything correctly — feedback is more than welcome!
Thanks to the OctoPrint community for making plugin development so accessible 🙌