Fix some warnings#155
Open
GerMalaz wants to merge 2 commits into
Open
Conversation
Use loop_control and loop_var as suggested.
Replace ansible_var_name with ansible_facts['var_name']
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some warnings when using this role:
```WARNING]:` The loop variable 'item' is already in use.
Origin:
item
You should set the
loop_varvalue in theloop_controloption for the task to something else to avoid variable collisions and unexpected behavior.Fix: as described, ansible_var_name -> ansible_facts['var_name']