fix: nodes that don't serve traffic dont get a jump-link

Author: centerorbit

README.md

@@ -143,6 +143,8 @@ PSSTD_ADVERTISE_HTTP=https://psstd.example.com/?psstd_node=node-a
 
 Traefik supports query-param matchers in router rules, so this keeps link clicks and hot-potato refreshes on a single DNS name while still selecting a specific backend. Start from `deploy/traefik/single-host-query.yaml`.
 
+That example also includes a low-priority host-only fallback route. If Traefik sees no matching `psstd_node` value, it sends the request to a shared `psstd-any` service instead of pinning fallback traffic to one node. Keep the `psstd-any` Endpoints list limited to nodes that should receive unrouted fallback traffic.
+
 ## Health Check
 
 ```bash

deploy/traefik/single-host-query.yaml

@@ -9,6 +9,8 @@
 #
 # Traefik routes by query parameter before forwarding the request, so hot-potato
 # refreshes and peer links still land on the intended node without per-node DNS.
+# Requests without a matching psstd_node value fall back to psstd-any. Keep that
+# Endpoints list limited to nodes that should receive unrouted fallback traffic.
 apiVersion: v1
 kind: Service
 metadata:
@@ -55,6 +57,30 @@ subsets:
       - name: http
         port: 8080
 ---
+apiVersion: v1
+kind: Service
+metadata:
+  name: psstd-any
+  namespace: default
+spec:
+  ports:
+    - name: http
+      port: 8080
+      targetPort: 8080
+---
+apiVersion: v1
+kind: Endpoints
+metadata:
+  name: psstd-any
+  namespace: default
+subsets:
+  - addresses:
+      - ip: 10.0.1.25
+      - ip: 10.0.1.26
+    ports:
+      - name: http
+        port: 8080
+---
 apiVersion: traefik.io/v1alpha1
 kind: IngressRoute
 metadata:
@@ -80,6 +106,6 @@ spec:
       kind: Rule
       priority: 1
       services:
-        - name: psstd-node-a
+        - name: psstd-any
           port: 8080
   tls: {}

render.go

@@ -364,6 +364,7 @@ type cellData struct {
 	URL     string
 	HTML    template.HTML
 	Offline bool
+	Link    bool
 }
 
 type pageData struct {
@@ -392,12 +393,17 @@ func makeHandler(db *pebble.DB, selfName string) http.HandlerFunc {
 		for _, s := range nodes {
 			htmlBytes := ansihtml.ConvertToHTML([]byte(renderANSI(s)))
 			offline := s.UpdatedAt == 0 || time.Since(time.Unix(0, s.UpdatedAt)) > 15*time.Second
+			nodeURL := ""
+			if s.WebURL != "" {
+				nodeURL = pageURL(s.WebURL, displayQuery(r, winW, winH))
+			}
 
 			cells = append(cells, cellData{
 				Name:    s.Name,
-				URL:     pageURL(s.WebURL, displayQuery(r, winW, winH)),
+				URL:     nodeURL,
 				HTML:    template.HTML(htmlBytes),
 				Offline: offline,
+				Link:    nodeURL != "",
 			})
 		}
 

render_test.go

@@ -0,0 +1,55 @@
+package main
+
+import (
+	"net/http/httptest"
+	"strings"
+	"testing"
+	"time"
+)
+
+func TestDashboardDoesNotLinkNodesWithoutWebURL(t *testing.T) {
+	db := openTestDB(t)
+	now := time.Now().UnixNano()
+	nodes := []NodeStats{
+		{
+			Name:      "sync-only",
+			Version:   appVersion,
+			UpdatedAt: now,
+			CPU:       []float64{10},
+			MemTotal:  100,
+			MemUsed:   25,
+		},
+		{
+			Name:      "web-node",
+			Version:   appVersion,
+			WebURL:    "https://psstd.example.com/?psstd_node=web-node",
+			UpdatedAt: now,
+			CPU:       []float64{20},
+			MemTotal:  100,
+			MemUsed:   30,
+		},
+	}
+	for _, node := range nodes {
+		if err := dbSet(db, node); err != nil {
+			t.Fatalf("set %s: %v", node.Name, err)
+		}
+	}
+
+	req := httptest.NewRequest("GET", "/?theme=dark&palette=monochrome", nil)
+	rr := httptest.NewRecorder()
+	makeHandler(db, "web-node").ServeHTTP(rr, req)
+
+	if rr.Code != 200 {
+		t.Fatalf("status = %d, want 200", rr.Code)
+	}
+	body := rr.Body.String()
+	if !strings.Contains(body, `<span class="node-name">sync-only</span>`) {
+		t.Fatalf("sync-only node was not rendered as non-link text:\n%s", body)
+	}
+	if strings.Contains(body, `<a href="/">sync-only</a>`) || strings.Contains(body, `>sync-only</a>`) {
+		t.Fatalf("sync-only node rendered as a link:\n%s", body)
+	}
+	if !strings.Contains(body, `>web-node</a>`) {
+		t.Fatalf("web node was not rendered as a link:\n%s", body)
+	}
+}

templates/dashboard.html

@@ -238,7 +238,8 @@
 .cell-header {
   margin-bottom: 8px;
 }
-.cell-header a {
+.cell-header a,
+.cell-header .node-name {
   color: var(--accent);
   text-decoration: none;
   font-weight: 700;
@@ -335,7 +336,7 @@
 </div>
 {{range .Nodes}}
 <div class="cell{{if .Offline}} offline{{end}}">
-  <div class="cell-header"><a href="{{.URL}}">{{.Name}}</a></div>
+  <div class="cell-header">{{if .Link}}<a href="{{.URL}}">{{.Name}}</a>{{else}}<span class="node-name">{{.Name}}</span>{{end}}</div>
   <pre>{{.HTML}}</pre>
 </div>
 {{end}}