fix classic ChildToParentMessage.hasExecuted#614
Conversation
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign one of the linked documents below to get yourself added. If you're an independent Individual please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=1353a816-a9c1-47ba-847e-ec79f0f23d31&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. If you're with a company (corporate) please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=2b5fe8ba-51d4-4980-b4ee-605d66e675d4&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. To agree to the CLA license, please fill out one of the attached forms. |
|
CLA link errors with "Cannot read properties of undefined (reading 'nextAction')" |
|
Daniel Goldman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This fixes two adjacent bugs in ChildToParentMessageClassic.hasExecuted:
Both bugs can cause
statusto returnUNCOMFIRMEDwhen it should returnCONFIRMEDE.g., see
https://retryable-dashboard.arbitrum.io/tx/0x9cea73b8c22cfcb12bc66be277d503ef6676b4e62024ed3dc4350953da235817 for a 1 example and
https://retryable-dashboard.arbitrum.io/tx/0xb68ab209d47527cbbaf8a59ac37243a150e3ed2daed74508fb645830a8f3ada9 for for a 2 example.
This ensures all reverts that other than those caused by improper inputs return false.