Skip to content

Commit ff89c1b

Browse files
Potential fix for pull request finding 'CodeQL / Shell command built from environment values'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
1 parent 79ebfdd commit ff89c1b

1 file changed

Lines changed: 16 additions & 9 deletions

File tree

packages/force-inclusion/scripts/force-inclusion-test.js

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -328,30 +328,37 @@ async function verifyOnFullnode(nodeConfigPath) {
328328
console.log('Starting fullnode via docker (sequencer disabled)...');
329329
let dockerContainerId;
330330
try {
331-
dockerContainerId = execSync(
332-
`docker run -d ` +
333-
`-v ${nodeConfigPath}:/config/nodeConfig.json ` +
334-
`-p 8449:8449 ` +
335-
`offchainlabs/nitro-node:v3.9.5-66e42c4 ` +
336-
`--conf.file /config/nodeConfig.json`,
331+
dockerContainerId = execFileSync(
332+
'docker',
333+
[
334+
'run',
335+
'-d',
336+
'-v',
337+
`${nodeConfigPath}:/config/nodeConfig.json`,
338+
'-p',
339+
'8449:8449',
340+
'offchainlabs/nitro-node:v3.9.5-66e42c4',
341+
'--conf.file',
342+
'/config/nodeConfig.json',
343+
],
337344
{ encoding: 'utf8' },
338345
).trim();
339346
console.log(`Container started: ${dockerContainerId.substring(0, 12)}`);
340347

341348
// Wait briefly then verify the container is still running
342349
await new Promise((r) => setTimeout(r, 3000));
343-
const running = execSync(`docker ps -q --filter id=${dockerContainerId}`, {
350+
const running = execFileSync('docker', ['ps', '-q', '--filter', `id=${dockerContainerId}`], {
344351
encoding: 'utf8',
345352
}).trim();
346353
if (!running) {
347354
console.error('Container exited immediately. Logs:');
348355
try {
349-
console.error(execSync(`docker logs ${dockerContainerId}`, { encoding: 'utf8' }));
356+
console.error(execFileSync('docker', ['logs', dockerContainerId], { encoding: 'utf8' }));
350357
} catch (_) {
351358
/* ignore */
352359
}
353360
try {
354-
execSync(`docker rm ${dockerContainerId}`, { encoding: 'utf8' });
361+
execFileSync('docker', ['rm', dockerContainerId], { encoding: 'utf8' });
355362
} catch (_) {
356363
/* ignore */
357364
}

0 commit comments

Comments
 (0)