[DO NOT MERGE] [MEL] Update rollup, challenge and osp tests#435
Draft
TucksonDev wants to merge 5 commits into
Draft
[DO NOT MERGE] [MEL] Update rollup, challenge and osp tests#435TucksonDev wants to merge 5 commits into
TucksonDev wants to merge 5 commits into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!! WIP - DO NOT MERGE !!
Note
This is a preliminary version, and can completely change, based on changes in the design or the implementation of the feature in nitro.
This PR builds on top of #432 and updates the tests of the Rollup, Challenge and OSP contracts. These changes are added to a different PR to allow for the base PR to only include relevant changes to the contracts, and not increase its size too much.
Key changes
test/challengeV2totest/foundry/challengeV2so they are run on CIGetEndParentChainBlockHash, new paths inReadPreimage, and deprecatedReadInboxopcodes)Pending work