Add TipCollectionToggler contract#439
Open
TucksonDev wants to merge 4 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+23
to
+28
| modifier onlyActivated() { | ||
| if (expiryTimestamp == 0) { | ||
| revert NotActivated(); | ||
| } | ||
| _; | ||
| } |
godzillaba
requested changes
Jul 1, 2026
godzillaba
left a comment
godzillaba
left a comment
Contributor
There was a problem hiding this comment.
LGTM! just a nit about events
we should probably wait for a precompiles release before merging to develop though
| if (block.timestamp < expiryTimestamp) { | ||
| revert NotExpired(); | ||
| } | ||
| ARB_OWNER.removeChainOwner(address(this)); |
Contributor
There was a problem hiding this comment.
nit but maybe we should add events to revoke and setCollectTips?
Contributor
There was a problem hiding this comment.
i know ArbOwner emits them too but can't hurt
Contributor
Author
There was a problem hiding this comment.
Thanks! The removeChainOwner method already emits a specific ChainOwnerRemoved in nitro (since ArbOS 60). But I've added a CollectTipsUpdated(bool) event for the setCollectTips method, since nitro only emits the generic OwnerActs event.
What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a TipCollectionToggler contract that allows a trusted party to enable/disable tip collection in a chain (available from ArbOS 60), during a specified time. This contract should be added as a chain owner.
It also updates the pin of the
precompilessubmodule to include the ArbOwner method that needs to be called.