Overhaul CI setup caching and harden build reproducibility#4502
Draft
joshuacolvin0 wants to merge 1 commit into
Draft
Overhaul CI setup caching and harden build reproducibility#4502joshuacolvin0 wants to merge 1 commit into
joshuacolvin0 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4502 +/- ##
==========================================
- Coverage 32.93% 29.16% -3.78%
==========================================
Files 495 495
Lines 58648 58648
==========================================
- Hits 19317 17103 -2214
- Misses 35912 38443 +2531
+ Partials 3419 3102 -317 |
Contributor
❌ 17 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
joshuacolvin0
force-pushed
the
improve-ci-caching
branch
2 times, most recently
from
17732ab to
84bc75a
Compare
Rework the ci-setup composite action to add proper caching for node_modules, solidity build artifacts, Go build/modules, and cbrotli, with validation and corruption detection on cache restore. Key changes: - Add dedicated cache steps for node_modules, solidity, Go, and cbrotli with carefully designed cache keys that include tool versions and all relevant source/config files via hashFiles() - Add self-validating cache key inputs: extract hashFiles() patterns from the action YAML and verify each pattern matches at least one file - Add cache-hit validation that checks cached directories exist and are non-empty before touching Make sentinels to skip rebuilds - Handle solidity/node_modules cache split-brain: purge solidity artifacts when node_modules cache is evicted to ensure consistent rebuilds - Add RETRY macro for npm/yarn installs to handle transient registry errors, with optional node_modules cleanup between attempts - Pin cbindgen version and skip reinstall when cached version matches - Use frozen lockfiles (npm ci / yarn --frozen-lockfile) in CI - Centralize node_modules and solidity directory lists as single source of truth consumed by both cache steps and validation - Add lint step that warns about cache-sensitive files not covered by any hashFiles() pattern - Harden install-rust action with set -euo pipefail and quoted outputs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joshuacolvin0
force-pushed
the
improve-ci-caching
branch
from
84bc75a to
019c56c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
● Summary
Test plan
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com