Skip to content

Fix typo in GetNativeTokenManagementFrom doc comment#4684

Open
anegg0 wants to merge 1 commit into
masterfrom
fix/native-token-management-comment-typo
Open

Fix typo in GetNativeTokenManagementFrom doc comment#4684
anegg0 wants to merge 1 commit into
masterfrom
fix/native-token-management-comment-typo

Conversation

@anegg0
Copy link
Copy Markdown
Contributor

@anegg0 anegg0 commented May 7, 2026

This PR fixes a typo in a comment in precompiles/ArbOwnerPublic.go.
I discovered it while using a script to update the docs for (3.9.9).
My docgen script was generating errors, partly due to this typo, and Claude spotted it.

The function name is spelled "Management" but the doc comment had
"Mangement". Aligns the comment with the function name.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.88%. Comparing base (6dce8d1) to head (bb25105).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4684      +/-   ##
==========================================
+ Coverage   52.38%   52.88%   +0.49%     
==========================================
  Files         506      506              
  Lines       73739    60415   -13324     
==========================================
- Hits        38630    31948    -6682     
+ Misses      29951    23381    -6570     
+ Partials     5158     5086      -72     

@anegg0 anegg0 requested a review from eljobe May 7, 2026 22:20
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
4962 5 4957 0
View the top 3 failed tests by shortest run time
TestMELMigrationFromLegacyNode
Stack Traces | 3.840s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [05-07|21:57:30.577] Ethereum protocol stopped
INFO [05-07|21:57:30.578] Transaction pool stopped
INFO [05-07|21:57:30.578] Submitted transaction                    hash=0x3cf76e436ea0b303e62c687134c043e574951fd678a942e46d29d7a4cfe51b04 from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=252 recipient=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 value=1
INFO [05-07|21:57:30.578] Persisting dirty state                   head=68  root=3b9d70..59e241 layers=68
INFO [05-07|21:57:30.579] Submitted transaction                    hash=0x4d6064e44c7537bf33cf00d602fad132637ea9f1a2c03b60004b0ee87265d2db from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=7   recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1,000,000,000,000
INFO [05-07|21:57:30.580] Starting work on payload                 id=0x03aa487e0ddfa327
INFO [05-07|21:57:30.581] Submitted transaction                    hash=0x1dec0d605c75bcc609546106cbe1097d1726c9db98b29f6a06fff2c572d387cf from=0xb386a74Dcab67b66F8AC07B4f08365d37495Dd23 nonce=101 recipient=0xbc1fbDdAcdd3412593Bc9bEC4A9d42699DE3BfAA value=0
INFO [05-07|21:57:30.581] DataPoster sent transaction              nonce=101 hash=1dec0d..d387cf feeCap=50,000,000,070 tipCap=5,000,000,000 blobFeeCap=&lt;nil&gt; gas=154,401
INFO [05-07|21:57:30.581] Updated payload                          id=0x03aa487e0ddfa327 number=44  hash=53ae1f..2ed691 txs=1   withdrawals=0 gas=21000      fees=0.002089429582 root=3d6012..c0908d elapsed="649.79µs"
INFO [05-07|21:57:30.581] BatchPoster: batch sent                  sequenceNumber=102 from=349 to=350 prevDelayed=98  currentDelayed=98  totalSegments=3  numBlobs=0
INFO [05-07|21:57:30.581] Stopping work on payload                 id=0x03aa487e0ddfa327 reason=delivery
INFO [05-07|21:57:30.581] Submitted transaction                    hash=0x68f650e5f7b6824a83e4e46cdd1ec821bda61a3cfdbc78ab5b436252b205ddb3 from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=248 recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1
INFO [05-07|21:57:30.582] Starting work on payload                 id=0x031a334d371ca695
INFO [05-07|21:57:30.582] Imported new potential chain segment     number=44  hash=53ae1f..2ed691 blocks=1  txs=1   mgas=0.021  elapsed="946.533µs" mgasps=22.186   triediffs=213.24KiB triedirty=0.00B
INFO [05-07|21:57:30.582] Chain head was updated                   number=44  hash=53ae1f..2ed691 root=3d6012..c0908d elapsed="70.837µs"
INFO [05-07|21:57:30.584] Persisted dirty state to disk            size=302.46KiB  elapsed=5.029ms
INFO [05-07|21:57:30.584] Blockchain stopped
INFO [05-07|21:57:30.584] Updated payload                          id=0x031a334d371ca695 number=443 hash=ce835b..78aba8 txs=2   withdrawals=0 gas=163,106    fees=0.00281053     root=c5bb2a..1374a6 elapsed=2.554ms
INFO [05-07|21:57:30.585] Stopping work on payload                 id=0x031a334d371ca695 reason=delivery
--- FAIL: TestMELMigrationFromLegacyNode (3.84s)
TestSequencerPriceAdjustsFrom25Gwei
Stack Traces | 5.500s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [05-07|21:57:49.816] DataPoster sent transaction              nonce=20  hash=e1ab99..b10520 feeCap=50,002,297,480 tipCap=5,000,000,000 blobFeeCap=&lt;nil&gt; gas=156,183
WARN [05-07|21:57:49.816] Served eth_getTransactionReceipt         reqid=21   duration="23.175µs"    err="transaction indexing is in progress"  errdata="\"transaction indexing is in progress\""
INFO [05-07|21:57:49.817] BatchPoster: batch sent                  sequenceNumber=21  from=56  to=58  prevDelayed=15  currentDelayed=15  totalSegments=5  numBlobs=0
INFO [05-07|21:57:49.817] Starting work on payload                 id=0x0300ece57f43385b
WARN [05-07|21:57:49.819] error applying transaction               tx="{\"type\":\"0x2\",\"chainId\":\"0x64aba\",\"nonce\":\"0x10e\",\"to\":\"0x0c709f340f0bb2e361229e345b7e26999d0969ab\",\"gas\":\"0x7a1200\",\"gasPrice\":\"0x0\",\"maxPriorityFeePerGas\":\"0xbebc200\",\"maxFeePerGas\":\"0xbebc200\",\"value\":\"0xe8d4a51000\",\"input\":\"0x\",\"accessList\":[],\"v\":\"0x0\",\"r\":\"0xdf4963485a7283d0654d893448fa218303e41e959f161d1347a0a56d6b98c0e4\",\"s\":\"0x4f968ee6eb6659dabed2006229e9299f053ccd70551e95a1d8a231a1ec627bb9\",\"yParity\":\"0x0\",\"hash\":\"0x2712e5c45d81800feae08d549320a6c995bc9c0e3d3f7eb5b306a8455ff58d59\"}" err="TimestampMin condition not met"
WARN [05-07|21:57:49.821] Served eth_sendRawTransactionConditional reqid=607  duration=6.031823ms    err="TimestampMin condition not met"
INFO [05-07|21:57:49.821] Updated payload                          id=0x0300ece57f43385b number=103 hash=6f6b9c..4b670a txs=1   withdrawals=0 gas=143,874    fees=0.00071937     root=cf7f99..abf4f6 elapsed=4.200ms
INFO [05-07|21:57:49.822] Stopping work on payload                 id=0x0300ece57f43385b reason=delivery
WARN [05-07|21:57:49.823] Served eth_getTransactionReceipt         reqid=22   duration="22.153µs"    err="transaction indexing is in progress"  errdata="\"transaction indexing is in progress\""
WARN [05-07|21:57:49.824] error applying transaction               tx="{\"type\":\"0x2\",\"chainId\":\"0x64aba\",\"nonce\":\"0x10e\",\"to\":\"0x0c709f340f0bb2e361229e345b7e26999d0969ab\",\"gas\":\"0x7a1200\",\"gasPrice\":\"0x0\",\"maxPriorityFeePerGas\":\"0xbebc200\",\"maxFeePerGas\":\"0xbebc200\",\"value\":\"0xe8d4a51000\",\"input\":\"0x\",\"accessList\":[],\"v\":\"0x0\",\"r\":\"0xdf4963485a7283d0654d893448fa218303e41e959f161d1347a0a56d6b98c0e4\",\"s\":\"0x4f968ee6eb6659dabed2006229e9299f053ccd70551e95a1d8a231a1ec627bb9\",\"yParity\":\"0x0\",\"hash\":\"0x2712e5c45d81800feae08d549320a6c995bc9c0e3d3f7eb5b306a8455ff58d59\"}" err="BlockNumberMin condition not met"
WARN [05-07|21:57:49.826] Served eth_sendRawTransactionConditional reqid=608  duration=4.576079ms    err="BlockNumberMin condition not met"
INFO [05-07|21:57:49.827] Imported new potential chain segment     number=103 hash=6f6b9c..4b670a blocks=1  txs=1   mgas=0.144  elapsed=4.929ms      mgasps=29.187   triediffs=502.00KiB triedirty=0.00B
INFO [05-07|21:57:49.827] Submitted transaction                    hash=0x94c5e663bde32a8461ca76806377aaf398c700c583ef7652e8ee5f9155e8dd21 from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=83  recipient=0x0C709F340F0BB2e361229e345B7e26999d0969Ab value=1
INFO [05-07|21:57:49.827] Chain head was updated                   number=103 hash=6f6b9c..4b670a root=cf7f99..abf4f6 elapsed="119.09µs"
WARN [05-07|21:57:49.828] error applying transaction               tx="{\"type\":\"0x2\",\"chainId\":\"0x64aba\",\"nonce\":\"0x10e\",\"to\":\"0x0c709f340f0bb2e361229e345b7e26999d0969ab\",\"gas\":\"0x7a1200\",\"gasPrice\":\"0x0\",\"maxPriorityFeePerGas\":\"0xbebc200\",\"maxFeePerGas\":\"0xbebc200\",\"value\":\"0xe8d4a51000\",\"input\":\"0x\",\"accessList\":[],\"v\":\"0x0\",\"r\":\"0xdf4963485a7283d0654d893448fa218303e41e959f161d1347a0a56d6b98c0e4\",\"s\":\"0x4f968ee6eb6659dabed2006229e9299f053ccd70551e95a1d8a231a1ec627bb9\",\"yParity\":\"0x0\",\"hash\":\"0x2712e5c45d81800feae08d549320a6c995bc9c0e3d3f7eb5b306a8455ff58d59\"}" err="BlockNumberMax condition not met"
INFO [05-07|21:57:49.828] Submitted transaction                    hash=0x2ddbf9fc1eafd29d37416c96bb3ded186db064b6006f6a5a6e05ec388b28a12d from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=45  recipient=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 value=1
INFO [05-07|21:57:49.828] InboxTracker                             sequencerBatchCount=10  messageCount=23  l1Block=42  l1Timestamp=2026-05-07T21:57:48+0000
WARN [05-07|21:57:49.828] Served eth_sendRawTransactionConditional reqid=609  duration=2.37924ms     err="BlockNumberMax condition not met"
WARN [05-07|21:57:49.829] Served eth_getBalance                    reqid=1    duration="52.44µs"     err="error from nodeA"
WARN [05-07|21:57:49.830] Served eth_getBalance                    reqid=25   duration="418.798µs"   err="error from nodeA"
TestRetryableFilteringFanoutAutoRedeemDirtyFirst
Stack Traces | 67.360s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [05-07|21:54:52.169] Imported new potential chain segment     number=447 hash=cadba6..86832e blocks=1  txs=1  mgas=0.021  elapsed=60.322ms     mgasps=0.348    triediffs=665.44KiB  triedirty=190.13KiB
INFO [05-07|21:54:52.169] Chain head was updated                   number=447 hash=cadba6..86832e root=82423a..2a930a elapsed="71.915µs"
INFO [05-07|21:54:52.170] ExecutionEngine: Added DelayedMessages   msgIdx=973 delayedMsgIdx=171 block-header="&amp;{ParentHash:0x742cc904bb01c5d2959ec8b1ade84b1046bb6bdbf9b33a6684fa5ff4bd5e5042 UncleHash:0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347 Coinbase:0xb386a74Dcab67b66F8AC07B4f08365d37495Dd23 Root:0xb1f473103ce730a106e349f1213984f98034c12b2bb1da0305091f3e61d1a9a4 TxHash:0x168bde6d2d87775b721388882257009916425c7f20c57d99041e35bb248a7a80 ReceiptHash:0xf08cf5553e1dae52e3df19b356b8320e17c39fb055f635739c31052db5c3e45e Bloom:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] Difficulty:+1 Number:+973 GasLimit:1125899906842624 GasUsed:0 Time:1778191024 Extra:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] MixDigest:0x0000000000000000000000000000015b00000000000000330000000000000000 Nonce:[0 0 0 0 0 0 0 172] BaseFee:+100000000 WithdrawalsHash:&lt;nil&gt; BlobGasUsed:&lt;nil&gt; ExcessBlobGas:&lt;nil&gt; ParentBeaconRoot:&lt;nil&gt; RequestsHash:&lt;nil&gt;}"
INFO [05-07|21:54:52.171] Ethereum protocol stopped
INFO [05-07|21:54:52.179] Starting work on payload                 id=0x03257bb92d525496
INFO [05-07|21:54:52.188] Updated payload                          id=0x0321bb1f621a80fe number=26  hash=e890d7..1e1d3d txs=1  withdrawals=0 gas=2,140,175  fees=2.140175e-06   root=4768b1..7d26e0 elapsed=24.439ms
INFO [05-07|21:54:52.189] Stopping work on payload                 id=0x0321bb1f621a80fe reason=delivery
INFO [05-07|21:54:52.190] Imported new potential chain segment     number=26  hash=e890d7..1e1d3d blocks=1  txs=1  mgas=2.140  elapsed=2.193ms      mgasps=975.901  triediffs=95.19KiB   triedirty=0.00B
INFO [05-07|21:54:52.197] Chain head was updated                   number=26  hash=e890d7..1e1d3d root=4768b1..7d26e0 elapsed=6.299896ms
INFO [05-07|21:54:52.204] Transaction pool stopped
INFO [05-07|21:54:52.205] Updated payload                          id=0x03257bb92d525496 number=552 hash=9c7de6..b90f7f txs=1  withdrawals=0 gas=21000      fees=0.0021         root=28af3b..c7794a elapsed=24.442ms
INFO [05-07|21:54:52.206] Persisting dirty state                   head=27  root=4a54ea..ec84a1 layers=27
INFO [05-07|21:54:52.217] ExecutionEngine: Added DelayedMessages   msgIdx=974 delayedMsgIdx=172 block-header="&amp;{ParentHash:0x3c99c8b51570bea1e7b102c7931b4db42812754d090917bcfd2712e73aef8aa6 UncleHash:0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347 Coinbase:0xb386a74Dcab67b66F8AC07B4f08365d37495Dd23 Root:0x484d6993a1ce1de822679d877e2cdfc1f573f1351d8f0071da053d01baaaa491 TxHash:0x2b1c6cdf6c3d866408d66143240beb2659690db71f530ac047417730f9f936f8 ReceiptHash:0xf08cf5553e1dae52e3df19b356b8320e17c39fb055f635739c31052db5c3e45e Bloom:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] Difficulty:+1 Number:+974 GasLimit:1125899906842624 GasUsed:0 Time:1778191025 Extra:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] MixDigest:0x0000000000000000000000000000015b00000000000000330000000000000000 Nonce:[0 0 0 0 0 0 0 173] BaseFee:+100000000 WithdrawalsHash:&lt;nil&gt; BlobGasUsed:&lt;nil&gt; ExcessBlobGas:&lt;nil&gt; ParentBeaconRoot:&lt;nil&gt; RequestsHash:&lt;nil&gt;}"
INFO [05-07|21:54:52.220] Persisted dirty state to disk            size=131.94KiB elapsed=14.174ms
INFO [05-07|21:54:52.232] Blockchain stopped
INFO [05-07|21:54:52.223] Stopping work on payload                 id=0x03257bb92d525496 reason=delivery
INFO [05-07|21:54:52.225] Imported new potential chain segment     number=552 hash=9c7de6..b90f7f blocks=1  txs=1  mgas=0.021  elapsed=19.703ms     mgasps=1.066    triediffs=655.45KiB  triedirty=271.98KiB
INFO [05-07|21:54:52.232] Chain head was updated                   number=552 hash=9c7de6..b90f7f root=28af3b..c7794a elapsed="97.813µs"
INFO [05-07|21:54:52.240] InboxTracker                             sequencerBatchCount=2   messageCount=2   l1Block=28  l1Timestamp=2026-05-07T21:54:49+0000
--- FAIL: TestRetryableFilteringFanoutAutoRedeemDirtyFirst (67.36s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant