Update CONTRIBUTING.md

[pmikolajczyk41]

closes NIT-4864

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.05%. Comparing base (6dce8d1) to head (66e83a4).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4685      +/-   ##
==========================================
- Coverage   52.39%   52.05%   -0.35%     
==========================================
  Files         506      506              
  Lines       73739    60415   -13324     
==========================================
- Hits        38634    31447    -7187     
+ Misses      29948    24085    -5863     
+ Partials     5157     4883     -274     

[github-actions]

❌ 7 Tests Failed:

Tests completed	Failed	Passed	Skipped
4924	7	4917	0

View the top 3 failed tests by shortest run time

TestEventProducer_Start

Stack Traces | 0.000s run time

=== RUN   TestEventProducer_Start
--- FAIL: TestEventProducer_Start (0.00s)
panic: send on closed channel [recovered, repanicked]

goroutine 26 [running]:
testing.tRunner.func1.2({0x65d800, 0x708820})
	/opt/hostedtoolcache/go/1.25.9/x64/src/testing/testing.go:1872 +0x237
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.25.9/x64/src/testing/testing.go:1875 +0x35b
panic({0x65d800?, 0x708820?})
	/opt/hostedtoolcache/go/1.25.9/x64/src/runtime/panic.go:783 +0x132
github.com/offchainlabs/nitro/bold/containers/events.(*Subscription[...]).Next(0x70d4c0, {0x70bc70?, 0xc0001666e0?})
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:134 +0xea
github.com/offchainlabs/nitro/bold/containers/events.TestEventProducer_Start(0xc000103a40)
	/home/runner/work/nitro/nitro/bold/containers/events/producer_test.go:65 +0xf2
testing.tRunner(0xc000103a40, 0x6c1818)
	/opt/hostedtoolcache/go/1.25.9/x64/src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	/opt/hostedtoolcache/go/1.25.9/x64/src/testing/testing.go:1997 +0x465

TestChallengeToFailedOSP

Stack Traces | 0.140s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
    challenge_test.go:38: goroutine 763 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.9/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x2de8870, 0xc0008ee000}, {0x2dc4ac0, 0xc000604fc0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x9f
        github.com/offchainlabs/nitro/staker/legacy.Require(0xc0008ee000, {0x2dc4ac0, 0xc000604fc0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/staker/legacy/common_test.go:14 +0x5d
        github.com/offchainlabs/nitro/staker/legacy.DeployOneStepProofEntry(0xc0008ee000, 0xc0001d0240, {0x2ddc490, 0xc001303968})
        	/home/runner/work/nitro/nitro/staker/legacy/challenge_test.go:38 +0x18d
        github.com/offchainlabs/nitro/staker/legacy.runChallengeTest(0xc0008ee000, 0xc0004367a0, {0x2ddf190, 0xc001302678}, 0x1, 0x0, 0x0)
        	/home/runner/work/nitro/nitro/staker/legacy/challenge_test.go:135 +0x425
        github.com/offchainlabs/nitro/staker/legacy.TestChallengeToFailedOSP(0xc0008ee000)
        	/home/runner/work/nitro/nitro/staker/legacy/challenge_test.go:269 +0xb2
        testing.tRunner(0xc0008ee000, 0x2be1058)
        	/opt/hostedtoolcache/go/1.25.9/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.9/x64/src/testing/testing.go:1997 +0x465
        
    challenge_test.go:38: �[31;1m [] replacement transaction underpriced �[0;0m
--- FAIL: TestChallengeToFailedOSP (0.14s)

TestSequencerInboxReader

Stack Traces | 3.790s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
DEBUG[05-11|12:38:52.313] Dereferenced trie from memory database   nodes=0   size=0.00B     time=190ns       gcnodes=743 gcsize=164.53KiB gctime=2.625447ms  livenodes=302  livesize=59.06KiB
DEBUG[05-11|12:38:52.313] Dereferenced trie from memory database   nodes=0   size=0.00B     time=180ns       gcnodes=743 gcsize=164.53KiB gctime=2.625537ms  livenodes=302  livesize=59.06KiB
DEBUG[05-11|12:38:52.313] Dereferenced trie from memory database   nodes=0   size=0.00B     time=201ns       gcnodes=743 gcsize=164.53KiB gctime=2.625638ms  livenodes=302  livesize=59.06KiB
DEBUG[05-11|12:38:52.313] Dereferenced trie from memory database   nodes=0   size=0.00B     time=190ns       gcnodes=743 gcsize=164.53KiB gctime=2.625728ms  livenodes=302  livesize=59.06KiB
DEBUG[05-11|12:38:52.313] Dereferenced trie from memory database   nodes=0   size=0.00B     time=191ns       gcnodes=743 gcsize=164.53KiB gctime=2.625819ms  livenodes=302  livesize=59.06KiB
DEBUG[05-11|12:38:52.313] Dereferenced trie from memory database   nodes=0   size=0.00B     time=180ns       gcnodes=743 gcsize=164.53KiB gctime=2.625899ms  livenodes=302  livesize=59.06KiB
DEBUG[05-11|12:38:52.313] Dereferenced trie from memory database   nodes=0   size=0.00B     time=181ns       gcnodes=743 gcsize=164.53KiB gctime=2.625979ms  livenodes=302  livesize=59.06KiB
DEBUG[05-11|12:38:52.313] Dereferenced trie from memory database   nodes=0   size=0.00B     time=191ns       gcnodes=743 gcsize=164.53KiB gctime=2.62607ms   livenodes=302  livesize=59.06KiB
DEBUG[05-11|12:38:52.313] Dereferenced trie from memory database   nodes=0   size=0.00B     time=180ns       gcnodes=743 gcsize=164.53KiB gctime=2.62615ms   livenodes=302  livesize=59.06KiB
DEBUG[05-11|12:38:52.313] Dereferenced trie from memory database   nodes=0   size=0.00B     time=190ns       gcnodes=743 gcsize=164.53KiB gctime=2.62624ms   livenodes=302  livesize=59.06KiB
DEBUG[05-11|12:38:52.313] Dereferenced trie from memory database   nodes=0   size=0.00B     time=171ns       gcnodes=743 gcsize=164.53KiB gctime=2.626321ms  livenodes=302  livesize=59.06KiB
DEBUG[05-11|12:38:52.313] Dereferenced trie from memory database   nodes=0   size=0.00B     time=191ns       gcnodes=743 gcsize=164.53KiB gctime=2.626411ms  livenodes=302  livesize=59.06KiB
DEBUG[05-11|12:38:52.313] Dereferenced trie from memory database   nodes=0   size=0.00B     time=180ns       gcnodes=743 gcsize=164.53KiB gctime=2.626491ms  livenodes=302  livesize=59.06KiB
INFO [05-11|12:38:52.313] Transaction pool stopped
INFO [05-11|12:38:52.313] Persisting dirty state                   root=057fa3..a935a7 layers=43
DEBUG[05-11|12:38:52.313] Journaled pathdb disk layer              root=057fa3..a935a7 id=44
INFO [05-11|12:38:52.313] Persisted dirty state to disk            size=50.60KiB  elapsed="670.753µs"
INFO [05-11|12:38:52.314] Blockchain stopped
TRACE[05-11|12:38:52.314] P2P networking is spinning down
--- FAIL: TestSequencerInboxReader (3.79s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov