Skip to content

prover: include global state in errored machine hash to match on-chain OSP #4712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dkutzmarks-rgb wants to merge 1 commit into from
+9 −1
Closed

prover: include global state in errored machine hash to match on-chain OSP #4712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion crates/prover/src/machine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2935,7 +2935,15 @@ impl Machine {
MachineStatus::Finished => {
crypto::keccak_seq(&[b"Machine finished:", self.global_state.hash().as_ref()])
}
MachineStatus::Errored => crypto::keccak_seq(&[b"Machine errored:"]),
// The global state must be committed here to match the on-chain OSP,
// which hashes an errored machine as keccak("Machine errored:" || globalStateHash)
// in both MachineLib.hash (per-step) and OneStepProofEntry.getMachineHash
// (block endpoint). Omitting it made a terminal Errored machine unadjudicable:
// the hash the honest validator commits here (via cgo) could never equal the
// hash the on-chain contract computes for the same state.
MachineStatus::Errored => {
crypto::keccak_seq(&[b"Machine errored:", self.global_state.hash().as_ref()])
}
MachineStatus::TooFar => crypto::keccak_seq(&[b"Machine too far:"]),
}
}
Expand Down
Loading