Skip to content

Add a go sdk toolchain with nodwarf5 for windows builds #15766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prestonvanloon wants to merge 2 commits into from
Closed

Add a go sdk toolchain with nodwarf5 for windows builds #15766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb090ae
Add a go sdk toolchain with nodwarf5 for windows builds
prestonvanloon Sep 27, 2025
1b81457
gazelle
prestonvanloon Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,15 +203,26 @@ load("@prysm//tools:image_deps.bzl", "prysm_image_deps")

prysm_image_deps()

load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")
load("@io_bazel_rules_go//go:deps.bzl", "go_download_sdk", "go_register_toolchains", "go_rules_dependencies")

go_rules_dependencies()

GO_VERSION = "1.25.1"

# Default toolchain.
go_register_toolchains(
go_version = "1.25.1",
go_version = GO_VERSION,
nogo = "@//:nogo",
)

# Go SDK for windows on go 1.25+ with an outdated gcc/zig sdk. See issue #15760.
# This must be configured at build time --@io_bazel_rules_go//go/toolchain:sdk_name=go_sdk_nodwarf5
go_download_sdk(
name = "go_sdk_nodwarf5",
experiments = ["nodwarf5"],
version = GO_VERSION,
)

load("//:distroless_deps.bzl", "distroless_deps")

distroless_deps()
Expand Down
1 change: 1 addition & 0 deletions build/bazelrc/cross.bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ build:osx_arm64 --cpu=aarch64
build:windows_amd64 --config=cross
build:windows_amd64 --platforms=@io_bazel_rules_go//go/toolchain:windows_amd64_cgo
build:windows_amd64 --compiler=mingw-w64
build:windows_amd64 --@io_bazel_rules_go//go/toolchain:sdk_name=go_sdk_nodwarf5 # See issue #15760

# linux_arm64 config for cross compiler toolchain
build:linux_arm64 --config=cross
Expand Down
3 changes: 3 additions & 0 deletions changelog/pvl-nodwarf5.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Changed

- Windows builds use GOEXPERIMENT=nodwarf5
Loading