You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(validation): downgrade missing thumbnail to warning when sample not in config (#1714)
When a sample is not found in samples-config-v3.json, the missing
thumbnail is a warning (not an error) since the sample is not in the
gallery anyway.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
result.passed.push(`assets/thumbnail.${ext} has 1600*920/800*460 resolution or same ratio.`);
74
74
}else{
75
-
result.failed.push(`assets/thumbnail.${ext} must have 1600*920/800*460 resolution or same ratio (40:23 aspect ratio). Current: ${dimensions.width}x${dimensions.height}.`);
75
+
result.warning.push(`assets/thumbnail.${ext} must have 1600*920/800*460 resolution or same ratio (40:23 aspect ratio). Current: ${dimensions.width}x${dimensions.height}.`);
76
76
}
77
77
break;
78
78
}
79
79
}
80
80
if(!thumbnailFound){
81
-
result.failed.push(`Thumbnail image is required to display in sample gallery. Please add thumbnailPath to samples-config-v3.json or add assets/thumbnail.png.`);
81
+
result.warning.push(`Thumbnail image not found. Add thumbnailPath to samples-config-v3.json or add assets/thumbnail.png to include this sample in the gallery.`);
0 commit comments