chore(deps): update rocket surgery other to v2 (#1771)

renovate[bot] · JoeRobich · web-flow · commit 1ce993ab99e1 · 2026-06-30T19:01:15.000Z
Co-authored-by: renovate[bot] &lt;29139614+renovate[bot]@users.noreply.github.com&gt;
Co-authored-by: Joey Robichaud &lt;joseph.robichaud@microsoft.com&gt;
diff --git a/.build/Build.cs b/.build/Build.cs
@@ -15,7 +15,6 @@ namespace Build;
 [PublicAPI]
 [UnsetVisualStudioEnvironmentVariables]
 [PackageIcon("http://www.omnisharp.net/images/logo.png")]
-[EnsureReadmeIsUpdated]
 [DotNetVerbosityMapping]
 [MSBuildVerbosityMapping]
 [NuGetVerbosityMapping]
@@ -25,7 +24,6 @@ public sealed partial class Solution : NukeBuild,
                                 ICanBuildWithDotNetCore,
                                 ICanTestWithDotNetCore,
                                 ICanPackWithDotNetCore,
-                                IHaveDataCollector,
                                 ICanClean,
                                 ICanUpdateReadme,
                                 IGenerateCodeCoverageReport,
@@ -51,17 +49,17 @@ public sealed partial class Solution : NukeBuild,
                                   .DependsOn(Test)
                                   .DependsOn(Pack);
 
-    public Target Build => _ => _.Inherit<ICanBuildWithDotNetCore>(x => x.CoreBuild);
+    public Target Build => _ => _.Inherit<ICanBuildWithDotNetCore>(x => x.DotnetCoreBuild);
 
-    public Target Pack => _ => _.Inherit<ICanPackWithDotNetCore>(x => x.CorePack)
+    public Target Pack => _ => _.Inherit<ICanPackWithDotNetCore>(x => x.DotnetCorePack)
                                 .DependsOn(Clean);
 
     [ComputedGitVersion] public GitVersion GitVersion { get; } = null!;
 
-    public Target Clean => _ => _.Inherit<ICanClean>(x => x.Clean);
-    public Target Restore => _ => _.Inherit<ICanRestoreWithDotNetCore>(x => x.CoreRestore);
+    public Target Clean => _ => _.Inherit<ICanClean>(x => x.CleanWellKnownTemporaryFiles);
+    public Target Restore => _ => _.Inherit<ICanRestoreWithDotNetCore>(x => x.DotnetCoreRestore);
 
-    public Target Test => _ => _.Inherit<ICanTestWithDotNetCore>(x => x.CoreTest);
+    public Target Test => _ => _.Inherit<ICanTestWithDotNetCore>(x => x.DotnetCoreTest);
 
     public Target NpmInstall => _ => _
         .Executes(() =>
@@ -79,6 +77,8 @@ public sealed partial class Solution : NukeBuild,
                                         .Before(Default)
                                         .Before(Clean);
 
+    public Target Docs => _ => _.Inherit<IGenerateDocFx>(x => x.GenerateDocFx);
+
     [Parameter("Configuration to build")] public Configuration Configuration { get; } = IsLocalBuild ? Configuration.Debug : Configuration.Release;
 
     AbsolutePath ICanUpdateReadme.ReadmeFilePath => RootDirectory / "README.md";
diff --git a/.build/Solution.cs b/.build/Solution.cs
@@ -56,7 +56,7 @@ internal class LocalConstants
     NonEntryTargets = new[]
     {
         nameof(ICIEnvironment.CIEnvironment),
-        nameof(ITriggerCodeCoverageReports.TriggerCodeCoverageReports),
+        nameof(ITriggerCodeCoverageReports.CollectCodeCoverage),
         nameof(ITriggerCodeCoverageReports.GenerateCodeCoverageReportCobertura),
         nameof(IGenerateCodeCoverageBadges.GenerateCodeCoverageBadges),
         nameof(IGenerateCodeCoverageReport.GenerateCodeCoverageReport),
@@ -96,7 +96,6 @@ RocketSurgeonGitHubActionsConfiguration configuration
     {
         configuration
             .ExcludeRepositoryConfigurationFiles()
-            .AddNugetPublish()
             .Jobs.OfType<RocketSurgeonsGithubActionsJob>()
             .First(z => z.Name.Equals("Build", StringComparison.OrdinalIgnoreCase))
             .ConfigureStep<CheckoutStep>(step => step.FetchDepth = 0)
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
@@ -29,6 +29,13 @@
         "jb"
       ],
       "rollForward": false
+    },
+    "dotnet-coverage": {
+      "version": "18.8.0",
+      "commands": [
+        "dotnet-coverage"
+      ],
+      "rollForward": false
     }
   }
 }
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -107,25 +107,25 @@ jobs:
       - name: 🎁 Restore
         id: restore
         run: |
-          dotnet nuke Restore --skip
+          dotnet nuke --target DotnetCoreRestore Restore
       - name: Update NuGet Cache
         if: always() && steps.restore-nuget-cache.outputs.cache-hit != 'true'
         uses: actions/cache/save@v6
         with:
           key: "${{ runner.os }}-nuget-${{ hashFiles('**/Directory.Packages.props') }}-${{ hashFiles('**/dotnet-tools.json') }}"
           path: '${{ github.workspace }}/.nuget/packages'
-      - name: ⚙ Build
+      - name: ⚙️ Build
         id: build
         run: |
-          dotnet nuke Build --skip
-      - name: 🚦 Test
+          dotnet .build/bin/Debug/.build.dll --target DotnetCoreBuild Build
+      - name: 💨 Test
         id: test
         run: |
-          dotnet nuke Test TriggerCodeCoverageReports GenerateCodeCoverageReportCobertura GenerateCodeCoverageBadges GenerateCodeCoverageSummary GenerateCodeCoverageReport --skip
+          dotnet .build/bin/Debug/.build.dll --target DotnetCoreTest Test CollectCodeCoverage GenerateCodeCoverageReportCobertura GenerateCodeCoverageBadges GenerateCodeCoverageSummary GenerateCodeCoverageReport
       - name: 📦 Pack
         id: pack
         run: |
-          dotnet nuke Pack --skip
+          dotnet .build/bin/Debug/.build.dll --target DotnetCorePack Pack --skip Build
       - name: Npm install
         working-directory: vscode-testextension
         run: |
diff --git a/.nuke/build.schema.json b/.nuke/build.schema.json
@@ -1,55 +1,77 @@
 {
   "$schema": "http://json-schema.org/draft-04/schema#",
-  "$ref": "#/definitions/build",
-  "title": "Build Schema",
   "definitions": {
-    "build": {
-      "type": "object",
+    "Host": {
+      "type": "string",
+      "enum": [
+        "AppVeyor",
+        "AzurePipelines",
+        "Bamboo",
+        "Bitbucket",
+        "Bitrise",
+        "GitHubActions",
+        "GitLab",
+        "Jenkins",
+        "Rider",
+        "SpaceAutomation",
+        "TeamCity",
+        "Terminal",
+        "TravisCI",
+        "VisualStudio",
+        "VSCode"
+      ]
+    },
+    "ExecutableTarget": {
+      "type": "string",
+      "enum": [
+        "Build",
+        "BuildVersion",
+        "Clean",
+        "CleanWellKnownTemporaryFiles",
+        "CollectCodeCoverage",
+        "Default",
+        "Docs",
+        "DotnetCoreBuild",
+        "DotnetCorePack",
+        "DotnetCoreRestore",
+        "DotnetCoreTest",
+        "DotnetToolRestore",
+        "GenerateCodeCoverageBadges",
+        "GenerateCodeCoverageReport",
+        "GenerateCodeCoverageReportCobertura",
+        "GenerateCodeCoverageSummary",
+        "GenerateDocFx",
+        "GenerateReadme",
+        "NpmInstall",
+        "Pack",
+        "Restore",
+        "Test",
+        "TestVscodeExtension"
+      ]
+    },
+    "Verbosity": {
+      "type": "string",
+      "description": "",
+      "enum": [
+        "Verbose",
+        "Normal",
+        "Minimal",
+        "Quiet"
+      ]
+    },
+    "NukeBuild": {
       "properties": {
-        "Artifacts": {
-          "type": "string",
-          "description": "The directory where artifacts are to be dropped"
-        },
-        "Configuration": {
-          "type": "string",
-          "description": "Configuration to build",
-          "enum": [
-            "Debug",
-            "Release"
-          ]
-        },
         "Continue": {
           "type": "boolean",
           "description": "Indicates to continue a previously failed build attempt"
         },
-        "Coverage": {
-          "type": "string",
-          "description": "The directory where coverage artifacts are to be dropped"
-        },
         "Help": {
           "type": "boolean",
           "description": "Shows the help text for this build assembly"
         },
         "Host": {
-          "type": "string",
           "description": "Host for execution. Default is 'automatic'",
-          "enum": [
-            "AppVeyor",
-            "AzurePipelines",
-            "Bamboo",
-            "Bitbucket",
-            "Bitrise",
-            "GitHubActions",
-            "GitLab",
-            "Jenkins",
-            "Rider",
-            "SpaceAutomation",
-            "TeamCity",
-            "Terminal",
-            "TravisCI",
-            "VisualStudio",
-            "VSCode"
-          ]
+          "$ref": "#/definitions/Host"
         },
         "NoLogo": {
           "type": "boolean",
@@ -74,95 +96,61 @@
           "type": "string",
           "description": "Root directory during build execution"
         },
-        "Serve": {
-          "type": "boolean",
-          "description": "serve the docs"
-        },
         "Skip": {
           "type": "array",
           "description": "List of targets to be skipped. Empty list skips all dependencies",
           "items": {
-            "type": "string",
-            "enum": [
-              "Build",
-              "BuildVersion",
-              "Clean",
-              "CoreBuild",
-              "CoreDocs",
-              "CorePack",
-              "CoreRestore",
-              "CoreTest",
-              "Default",
-              "DotnetToolRestore",
-              "Generate_Code_Coverage_Badges",
-              "Generate_Code_Coverage_Report",
-              "Generate_Code_Coverage_Report_Cobertura",
-              "Generate_Code_Coverage_Summary",
-              "GenerateCodeCoverageBadges",
-              "GenerateCodeCoverageReport",
-              "GenerateCodeCoverageReportCobertura",
-              "GenerateCodeCoverageSummary",
-              "GenerateReadme",
-              "NpmInstall",
-              "Pack",
-              "Restore",
-              "Test",
-              "TestVscodeTestExtension",
-              "Trigger_Code_Coverage_Reports",
-              "TriggerCodeCoverageReports"
-            ]
+            "$ref": "#/definitions/ExecutableTarget"
           }
         },
-        "Solution": {
-          "type": "string",
-          "description": "Path to a solution file that is automatically loaded"
-        },
         "Target": {
           "type": "array",
           "description": "List of targets to be invoked. Default is '{default_target}'",
           "items": {
-            "type": "string",
-            "enum": [
-              "Build",
-              "BuildVersion",
-              "Clean",
-              "CoreBuild",
-              "CoreDocs",
-              "CorePack",
-              "CoreRestore",
-              "CoreTest",
-              "Default",
-              "DotnetToolRestore",
-              "Generate_Code_Coverage_Badges",
-              "Generate_Code_Coverage_Report",
-              "Generate_Code_Coverage_Report_Cobertura",
-              "Generate_Code_Coverage_Summary",
-              "GenerateCodeCoverageBadges",
-              "GenerateCodeCoverageReport",
-              "GenerateCodeCoverageReportCobertura",
-              "GenerateCodeCoverageSummary",
-              "GenerateReadme",
-              "NpmInstall",
-              "Pack",
-              "Restore",
-              "Test",
-              "TestVscodeTestExtension",
-              "Trigger_Code_Coverage_Reports",
-              "TriggerCodeCoverageReports"
-            ]
+            "$ref": "#/definitions/ExecutableTarget"
           }
         },
         "Verbosity": {
-          "type": "string",
           "description": "Logging verbosity during build execution. Default is 'Normal'",
+          "$ref": "#/definitions/Verbosity"
+        }
+      }
+    }
+  },
+  "allOf": [
+    {
+      "properties": {
+        "Artifacts": {
+          "type": "string",
+          "description": "The directory where artifacts are to be dropped"
+        },
+        "Configuration": {
+          "type": "string",
+          "description": "Configuration to build",
           "enum": [
-            "Minimal",
-            "Normal",
-            "Quiet",
-            "Verbose"
+            "Debug",
+            "Release"
           ]
+        },
+        "Coverage": {
+          "type": "string",
+          "description": "The directory where coverage artifacts are to be dropped"
+        },
+        "Serve": {
+          "type": [
+            "boolean",
+            "null"
+          ],
+          "description": "serve the docs"
+        },
+        "Solution": {
+          "type": "string",
+          "description": "Path to a solution file that is automatically loaded"
         }
       }
+    },
+    {
+      "$ref": "#/definitions/NukeBuild"
     }
-  }
+  ]
 }
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -26,7 +26,7 @@
     <PackageVersion Include="GitVersion.Tool" Version="6.7.0" />
     <PackageVersion Include="JetBrains.ReSharper.CommandLineTools" Version="2025.2.6" />
     <PackageVersion Include="ReportGenerator" Version="5.5.10" />
-    <PackageVersion Include="Rocket.Surgery.Nuke" Version="1.8.36" />
+    <PackageVersion Include="Rocket.Surgery.Nuke" Version="2.9.12" />
   </ItemGroup>
   <ItemGroup>
     <!-- backwards compat is maintained in Directory.Packages.supports.props -->
diff --git a/test/coverlet.runsettings b/test/coverlet.runsettings

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,13 @@`
`29`	`29`	`"jb"`
`30`	`30`	`],`
`31`	`31`	`"rollForward": false`
	`32`	`+ },`
	`33`	`+ "dotnet-coverage": {`
	`34`	`+ "version": "18.8.0",`
	`35`	`+ "commands": [`
	`36`	`+ "dotnet-coverage"`
	`37`	`+ ],`
	`38`	`+ "rollForward": false`
`32`	`39`	`}`
`33`	`40`	`}`
`34`	`41`	`}`