Fix CLI-created API keys returning 401 permission denied#456
Merged
Conversation
doCreate() was passing incorrect arguments to getOrCreateUserForIndexKey(): empty string for credentials and true for isAnonymous, causing keys to be created with ROLE_ANONYMOUS instead of ROLE_USER. Pass the actual key value and false to match the working pattern in CreateApiKeyAction. Fixes #455
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doCreate()inApiKeyCliMainpassing incorrect arguments togetOrCreateUserForIndexKey(): empty string for credentials andtrueforisAnonymous, causing keys to be created withROLE_ANONYMOUSinstead ofROLE_USERfalseto match the working pattern inCreateApiKeyActionFixes #455
Test plan
onebusaway-api-key-clipass