Skip to content

Fix CLI-created API keys returning 401 permission denied #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronbrethorst merged 1 commit into from
Feb 8, 2026
Merged

Fix CLI-created API keys returning 401 permission denied #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion onebusaway-api-key-cli/src/main/java/org/onebusaway/cli/apikey/ApiKeyCliMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ private void doCreate(CommandLine cli, boolean jsonOutput) throws Exception {
}

// Create the key
UserIndex userIndex = userService.getOrCreateUserForIndexKey(indexKey, "", true);
UserIndex userIndex = userService.getOrCreateUserForIndexKey(indexKey, keyValue, false);
userPropertiesService.authorizeApi(userIndex.getUser(), minApiReqInt);

User user = userIndex.getUser();
Expand Down
8 changes: 4 additions & 4 deletions onebusaway-api-key-cli/src/test/java/org/onebusaway/cli/apikey/ApiKeyCliMainTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,12 +249,12 @@ public void testCreate_NewKey_Success() throws Exception {
User mockUser = mockUserIndex.getUser();

when(userService.getUserIndexForId(any(UserIndexKey.class))).thenReturn(null);
when(userService.getOrCreateUserForIndexKey(any(UserIndexKey.class), eq(""), eq(true)))
when(userService.getOrCreateUserForIndexKey(any(UserIndexKey.class), eq("test-key-123"), eq(false)))
.thenReturn(mockUserIndex);

cli.run(new String[]{"create", "--config", "/tmp/data-sources.xml", "--key", keyValue});

verify(userService).getOrCreateUserForIndexKey(any(UserIndexKey.class), eq(""), eq(true));
verify(userService).getOrCreateUserForIndexKey(any(UserIndexKey.class), eq("test-key-123"), eq(false));
verify(userPropertiesService).authorizeApi(eq(mockUser), anyLong());
verify(userPropertiesService).updateApiKeyContactInfo(eq(mockUser), anyString(), anyString(), anyString(), anyString());
assertTrue(outContent.toString().contains("API key created successfully"));
Expand All @@ -267,7 +267,7 @@ public void testCreate_WithContactInfo_Success() throws Exception {
User mockUser = mockUserIndex.getUser();

when(userService.getUserIndexForId(any(UserIndexKey.class))).thenReturn(null);
when(userService.getOrCreateUserForIndexKey(any(UserIndexKey.class), eq(""), eq(true)))
when(userService.getOrCreateUserForIndexKey(any(UserIndexKey.class), eq("test-key-456"), eq(false)))
.thenReturn(mockUserIndex);

cli.run(new String[]{
Expand Down Expand Up @@ -515,7 +515,7 @@ public void testCreate_JsonOutput_Success() throws Exception {
User mockUser = mockUserIndex.getUser();

when(userService.getUserIndexForId(any(UserIndexKey.class))).thenReturn(null);
when(userService.getOrCreateUserForIndexKey(any(UserIndexKey.class), eq(""), eq(true)))
when(userService.getOrCreateUserForIndexKey(any(UserIndexKey.class), eq("json-test-key"), eq(false)))
.thenReturn(mockUserIndex);

cli.run(new String[]{
Expand Down
Loading