Merge pull request #2062 from OneCommunityGlobal/Sayali_Fix_Years_Of_Experience_Display

Sayali: add updateYearsOfExperience endpoint with validation and upsert

Author: one-community

src/controllers/userSkillsProfileController.js

@@ -17,9 +17,6 @@ const userSkillsProfileController = function (UserProfile) {
    * Returns consistent structure regardless of data availability
    */
   const getUserSkillsProfile = async (req, res, next) => {
-    console.log('req.body.requestor');
-    console.log(req.body.requestor);
-
     try {
       // Check if user has permission to view user profiles
       const hasAccess = await hasPermission(req.body.requestor, 'getUserProfiles');
@@ -86,7 +83,9 @@ const userSkillsProfileController = function (UserProfile) {
 
       // Get skills data - use default values if not found
       const userIdObj = mongoose.Types.ObjectId(userId);
-      const formResponses = await HgnFormResponses.findOne({ user_id: userIdObj })
+      const formResponses = await HgnFormResponses.findOne({
+        $or: [{ user_id: userIdObj }, { user_id: userId }],
+      })
         .sort({ _id: -1 })
         .lean();
       // Flag if we're using real or placeholder data
@@ -224,12 +223,6 @@ const userSkillsProfileController = function (UserProfile) {
   }
   //
   const updateUserSkillsProfileFollowUp = async (req, res, next) => {
-    console.log('updateUserSkillsProfileFollowUp');
-
-    console.log('req.body.requestor');
-    console.log(req.body);
-
-    console.log(req.params?.userId);
     try {
       // Check if user has permission to view user profiles
       const hasAccess = await hasPermission(req.body.requestor, 'updateUserSkillsProfileFollowUp');
@@ -315,8 +308,6 @@ const userSkillsProfileController = function (UserProfile) {
 
       return res.status(200).json({ data: formResponsesUpd });
     } catch (error) {
-      console.log('error');
-      console.log(error);
       // Log exceptions with transaction name and relevant data
       Logger.logException(error, 'updateUserSkillsProfileFollowUp', {
         requestorId: req.body.requestor?.requestorId,
@@ -326,11 +317,54 @@ const userSkillsProfileController = function (UserProfile) {
       next(error);
     }
   };
+  const updateYearsOfExperience = async (req, res, next) => {
+    try {
+      const hasAccess =
+        req.body.requestor.requestorId === req.params.userId ||
+        (await hasPermission(req.body.requestor, 'updateUserSkillsProfileFollowUp'));
+      if (!hasAccess) {
+        return res.status(403).json({ error: 'You do not have permission to update this profile' });
+      }
+
+      const { userId } = req.params;
+
+      if (!mongoose.Types.ObjectId.isValid(userId)) {
+        throw new ValidationError('Invalid user ID format');
+      }
+
+      const { yearsOfExperience } = req.body;
+
+      if (yearsOfExperience !== '' && yearsOfExperience != null) {
+        const num = Number(yearsOfExperience);
+        if (!Number.isInteger(num) || num < 0) {
+          return res
+            .status(400)
+            .json({ error: 'Years of Experience must be a non-negative whole number' });
+        }
+      }
+
+      const updatedResponse = await HgnFormResponses.findOneAndUpdate(
+        { user_id: mongoose.Types.ObjectId(userId) },
+        { 'general.yearsOfExperience': yearsOfExperience },
+        { new: true, sort: { _id: -1 }, upsert: true },
+      );
+
+      return res.status(200).json({ data: updatedResponse });
+    } catch (error) {
+      Logger.logException(error, 'updateYearsOfExperience', {
+        requestorId: req.body.requestor?.requestorId,
+        targetUserId: req.params?.userId,
+        timestamp: new Date().toISOString(),
+      });
+      next(error);
+    }
+  };
 
   //
   return {
     getUserSkillsProfile,
     updateUserSkillsProfileFollowUp,
+    updateYearsOfExperience,
   };
 };
 

src/routes/userSkillsProfileRouter.js

@@ -19,6 +19,10 @@ const routes = function (UserProfile) {
     .route('/skills/profile/updateFollowUp/:userId')
     .put(controller.updateUserSkillsProfileFollowUp);
 
+  userSkillsProfileRouter
+    .route('/skills/profile/updateYearsOfExperience/:userId')
+    .put(controller.updateYearsOfExperience);
+
   return userSkillsProfileRouter;
 };