Merge pull request #2083 from OneCommunityGlobal/linh_backend_fix_faq_log_question_error

Linh - Fix FAQ unanswered question API false 500 and duplicate detection

Author: one-community

src/controllers/faqController.js

@@ -151,16 +151,28 @@ const logUnansweredFAQ = async function (req, res) {
   try {
     await verifyToken(req);
 
-    const { question } = req.body;
+    const rawQuestion = req.body?.question;
+    const normalizedQuestion = rawQuestion?.replaceAll(/\s+/g, ' ').trim();
+    if (!normalizedQuestion) {
+      return res.status(400).json({ message: 'Question is required' });
+    }
     const createdBy = req.user.userid;
 
-    const existingQuestion = await UnansweredFAQ.findOne({ question });
+    const escapedQuestion = normalizedQuestion.replaceAll(/[.*+?^${}()|[\]\\]/g, String.raw`\$&`);
+    const flexibleWhitespaceQuestion = escapedQuestion.replaceAll(/\s+/g, String.raw`\s+`);
+    const duplicateQuestionPattern = new RegExp(
+      String.raw`^\s*${flexibleWhitespaceQuestion}\s*$`,
+      'i',
+    );
+    const existingQuestion = await UnansweredFAQ.findOne({
+      question: { $regex: duplicateQuestionPattern },
+    });
     if (existingQuestion) {
       return res.status(409).json({ message: 'This question has already been logged' });
     }
 
     const newUnansweredFAQ = new UnansweredFAQ({
-      question,
+      question: normalizedQuestion,
       createdBy,
       createdAt: new Date().toISOString(),
     });
@@ -172,25 +184,30 @@ const logUnansweredFAQ = async function (req, res) {
       ownerEmails = [process.env.TEST_OWNER_EMAIL];
       console.log('Test mode enabled. Using test owner email:', ownerEmails);
     } else {
-      const owners = await UserProfile.find({ role: 'owner' }).select('email');
+      const owners = await UserProfile.find({ role: /^owner$/i }).select('email');
       ownerEmails = owners.map((owner) => owner.email);
 
       if (ownerEmails.length === 0) {
         console.warn('No owner emails found in the database.');
-        return res.status(500).json({ message: 'No owner emails found' });
       }
-      console.log('Sending email to owners:', ownerEmails);
+      if (ownerEmails.length > 0) {
+        console.log('Sending email to owners:', ownerEmails);
+      }
     }
 
     const emailMessage = `
             <p>A new unanswered question has been logged:</p>
-            <p><strong>Question:</strong> ${question}</p>
+            <p><strong>Question:</strong> ${normalizedQuestion}</p>
             <p>Please review and add an answer if necessary.</p>
         `;
 
     try {
-      emailSender(ownerEmails, 'New Unanswered FAQ Logged', emailMessage);
-      console.log('Email successfully sent.');
+      if (ownerEmails.length > 0) {
+        emailSender(ownerEmails, 'New Unanswered FAQ Logged', emailMessage);
+        console.log('Email successfully sent.');
+      } else {
+        console.warn('Skipping owner notification email because no owner email was found.');
+      }
     } catch (error) {
       console.error('Error sending email:', error);
     }