Yu Yan taking over for Ujjwal - fix: Removed userId of deleted users from task->resources and teams->members#1748
Closed
PipKcK wants to merge 1 commit intodevelopmentfrom
Closed
Conversation
Anusha-Gali
suggested changes
Dec 16, 2025
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Ujjwal,
I have tried to review your PR locally but was unable to add the new user to the task even though i could add them to the teams. Could you please look into it and let me know if i am not doing any step wrong as even the names are not popping up in the Resources.
Testpr1748.mp4
Member
|
Redone with: #2149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Users that were deleted were not removed from Projects that they were assigned to. This PR ensures that when a user is deleted, they are also removed from Task->Resources (Which is responsible for Projects) and Teams->Members.
Related PRS (if any):
None
Main changes explained:
userProfileController.js'sdeleteUserProfilefunction to remove the deleted userIds from other collections (tasks and teams)How to test:
npm run buildandnpm startto run this PR locallytasksandteamscollectionshttp://localhost:4500/api/userProfile/{userId_to_delete}with the body: