Deep - Fix - Volunteer status pie chart#1759
Conversation
|
Reviewed the working of PR #1759 Also, added relevant comments to the frontend PR #4138 |
akshith312
left a comment
There was a problem hiding this comment.
Provided Feedback on related FE PR 4138.
Aswin20010
left a comment
There was a problem hiding this comment.
Tested the new Mentor Status Pie Chart under Reports → Total Org Summary. Verified data rendering from mentorNumberStats, correct alignment beside the volunteer chart, and consistent count updates based on date filters. Confirmed the connector lines and pill-shaped callouts render correctly using externalLabelGuidesPlugin.js. Checked layout spacing, responsiveness, and dark mode — all functioning as expected. Approved the Frontend and related Backend PR.
Aditya-gam
left a comment
There was a problem hiding this comment.
- Reviewed this PR by testing the frontend on localhost and left a review requesting changes on the frontend PR #4138.
- Backend properly returns the data to the client site, but there is an issue with data aggregation.
- New mentors who remain active are counted twice: once in "active" AND once in "new," inflating the total and making percentages misleading (e.g., 3 new active mentors → counted as 6 in the total).
- This same issue exists for the volunteer status donut chart too, and I have tried to fix it in these PRs: #4191 + #1794
- Test Video:
TestVideo.mov
|
Thank you all, merging! |
Hi @Aditya-gam, good observation. I've made the changes. Thanks |



Description
Added a new pie chart to show
Total Mentorsnext toTotal Volunteerpie chartRelated PRS (if any):
To test this backend PR you need to checkout the #4138 frontend PR.
Main changes explained:
getVolunteerStatsDatanow calls a new helper for mentor counts and returns amentorNumberStatsblock alongside the volunteer numbers (reportsController.js).getMentorNumberStatsinoverviewReportHelper.js; it mirrors the volunteer aggregation but filters role: 'Mentor', counting Active/New/Deactivated mentors and computing percentages plus optional comparison deltas.getMentorNumberStatsin the helper’s export so other code can consume the same mentor breakdown whenever needed.How to test:
deep-fix-volunteer-status-pie-chartbranch in the backend.deep-fix-volunteer-status-pie-chartbranch in frontend and run it to test.npm install, and...to run this PR locally.Screenshots or videos of changes:
Before:
Screen.Recording.2025-09-28.at.14.46.46.mov
After:
Screen.Recording.2025-09-28.at.14.41.37.mov