Skip to content

Alisha - fix: Job Posting Page – “Select Category” Filter Returns No Listings #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alishawalunj wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Alisha - fix: Job Posting Page – “Select Category” Filter Returns No Listings #2135

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80a2343
fix: category filter parsing using JSON in jobs APIs
alishawalunj Mar 27, 2026
83ae696
fix: resolved search query to fecth data
alishawalunj Apr 13, 2026
0c5e418
fix: update regex for job category
alishawalunj Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 83 additions & 42 deletions src/controllers/jobsController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,57 +5,72 @@
UTILS
============================================================ */

// Prevent regex injection / crashes
const escapeRegex = (text) => text.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
const escapeRegex = (text = '') => text.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');

Check warning on line 8 in src/controllers/jobsController.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

`String.raw` should be used to avoid escaping `\`. 


See more on https://sonarcloud.io/project/issues?id=OneCommunityGlobal_HGNRest&issues=AZ2E-WbedmrT2FrTRgOK&open=AZ2E-WbedmrT2FrTRgOK&pullRequest=2135

// Build query (REUSABLE)
const buildJobQuery = ({ search = '', category = '', position = '' }) => {
const parseCategory = (category) => {
if (!category) return [];

if (Array.isArray(category)) return category;

try {
const parsed = JSON.parse(category);
return Array.isArray(parsed) ? parsed : [];
} catch {
return category
.split(',')
.map((c) => c.trim())
.filter(Boolean);
}
};

const buildConditions = ({ search, category, position }) => {
const conditions = [];

/* SEARCH FILTER */
if (search && search.trim() !== '') {
const safeSearch = escapeRegex(search.trim());
/* SEARCH */
if (search?.trim()) {
const safe = escapeRegex(search.trim());
conditions.push({
$or: [
{ title: { $regex: safeSearch, $options: 'i' } },
{ description: { $regex: safeSearch, $options: 'i' } },
{ title: { $regex: safe, $options: 'i' } },
{ description: { $regex: safe, $options: 'i' } },
],
});
}

/* POSITION FILTER (uses title) */
if (position && position.trim() !== '') {
const safePosition = escapeRegex(position.trim());
/* POSITION */
if (position?.trim()) {
const safe = escapeRegex(position.trim());
conditions.push({
title: { $regex: `^${safePosition}`, $options: 'i' },
title: { $regex: `^${safe}`, $options: 'i' },
});
}

/* CATEGORY FILTER */
if (category && category.trim() !== '') {
const categoryList = category.split(',').map((c) => c.trim());
/* CATEGORY */
const categoryList = parseCategory(category);
if (categoryList.length > 0) {
conditions.push({ category: { $in: categoryList } });
}

return conditions.length ? { $and: conditions } : {};
};

/* ============================================================
INTERNAL: MAIN PAGINATION + FILTERING LOGIC
PAGINATION CONTROLLER
============================================================ */

const paginationForJobs = async (req, res) => {
const { page = 1, limit = 18, search = '', category = '', position = '' } = req.query;

try {
const pageNumber = Math.max(1, parseInt(page, 10));
const limitNumber = Math.max(1, parseInt(limit, 10));

const query = buildJobQuery({ search, category, position });
const query = buildConditions({ search, category, position });

const totalJobs = await Job.countDocuments(query);
const totalPages = Math.max(1, Math.ceil(totalJobs / limitNumber));

const pageNum = pageNumber > totalPages ? 1 : pageNumber;
const pageNum = Math.min(pageNumber, totalPages);

const jobs = await Job.find(query)
.sort({ displayOrder: 1, featured: -1, datePosted: -1, title: 1 })
Expand Down Expand Up @@ -84,19 +99,17 @@
}
};

/* ============================================================
EXPORT: GET JOBS WITH PAGINATION
============================================================ */
const getJobs = (req, res) => paginationForJobs(req, res);

/* ============================================================
JOB SUMMARIES
============================================================ */

const getJobSummaries = async (req, res) => {
const { search = '', category = '', position = '' } = req.query;

try {
const query = buildJobQuery({ search, category, position });
const query = buildConditions({ search, category, position });

const jobs = await Job.find(query)
.select('title category location description datePosted featured jobDetailsLink')
Expand All @@ -105,7 +118,11 @@

const totalJobs = jobs.length;

res.json({ success: true, jobs, totalJobs });
res.json({
success: true,
jobs,
totalJobs,
});
} catch (error) {
res.status(500).json({
success: false,
Expand All @@ -118,8 +135,10 @@
/* ============================================================
OTHER CONTROLLERS
============================================================ */

const getJobTitleSuggestions = async (req, res) => {
const { query = '' } = req.query;

try {
const suggestions = await Job.find({
title: { $regex: query, $options: 'i' },
Expand All @@ -138,32 +157,30 @@
const pageNumber = Math.max(1, parseInt(page, 10));
const limitNumber = Math.max(1, parseInt(limit, 10));

const sortCriteria = {
displayOrder: 1,
featured: -1,
datePosted: -1,
title: 1,
};

const totalJobs = await Job.countDocuments({});
const totalPages = Math.ceil(totalJobs / limitNumber);

const jobs = await Job.find({})
.sort(sortCriteria)
.sort({ displayOrder: 1, featured: -1, datePosted: -1, title: 1 })
.skip((pageNumber - 1) * limitNumber)
.limit(limitNumber);

res.json({
jobs,
pagination: {
totalJobs,
totalPages: Math.ceil(totalJobs / limitNumber),
totalPages,
currentPage: pageNumber,
limit: limitNumber,
hasNextPage: pageNumber < Math.ceil(totalJobs / limitNumber),
hasNextPage: pageNumber < totalPages,
hasPreviousPage: pageNumber > 1,
},
});
} catch (error) {
res.status(500).json({ error: 'Failed to reset filters', details: error.message });
res.status(500).json({
error: 'Failed to reset filters',
details: error.message,
});
}
};

Expand All @@ -189,20 +206,25 @@

const getJobById = async (req, res) => {
const { id } = req.params;

try {
const job = await Job.findById(id);
if (!job) return res.status(404).json({ error: 'Job not found' });

res.json(job);
} catch (error) {
res.status(500).json({ error: 'Failed to fetch job', details: error.message });
res.status(500).json({
error: 'Failed to fetch job',
details: error.message,
});
}
};

const createJob = async (req, res) => {
const { title, category, description, imageUrl, location, applyLink, jobDetailsLink } = req.body;

try {
const highestOrderJob = await Job.findOne().sort({ displayOrder: -1 }).limit(1);
const highestOrderJob = await Job.findOne().sort({ displayOrder: -1 });
const newDisplayOrder = highestOrderJob ? highestOrderJob.displayOrder + 1 : 0;

const newJob = new Job({
Expand All @@ -219,7 +241,10 @@
const savedJob = await newJob.save();
res.status(201).json(savedJob);
} catch (error) {
res.status(500).json({ error: 'Failed to create job', details: error.message });
res.status(500).json({
error: 'Failed to create job',
details: error.message,
});
}
};

Expand All @@ -229,9 +254,13 @@
try {
const updatedJob = await Job.findByIdAndUpdate(id, req.body, { new: true });
if (!updatedJob) return res.status(404).json({ error: 'Job not found' });

res.json(updatedJob);
} catch (error) {
res.status(500).json({ error: 'Failed to update job', details: error.message });
res.status(500).json({
error: 'Failed to update job',
details: error.message,
});
}
};

Expand All @@ -241,18 +270,23 @@
try {
const deletedJob = await Job.findByIdAndDelete(id);
if (!deletedJob) return res.status(404).json({ error: 'Job not found' });

res.json({ message: 'Job deleted successfully' });
} catch (error) {
res.status(500).json({ error: 'Failed to delete job', details: error.message });
res.status(500).json({
error: 'Failed to delete job',
details: error.message,
});
}
};

const reorderJobs = async (req, res) => {
const { jobIds } = req.body;

try {
if (!Array.isArray(jobIds) || jobIds.length === 0)
if (!Array.isArray(jobIds) || jobIds.length === 0) {
return res.status(400).json({ error: 'Invalid job order data' });
}

const updateOperations = jobIds.map((jobId, index) => ({
updateOne: {
Expand All @@ -271,10 +305,17 @@
jobs,
});
} catch (error) {
res.status(500).json({ error: 'Failed to reorder jobs', details: error.message });
res.status(500).json({
error: 'Failed to reorder jobs',
details: error.message,
});
}
};

/* ============================================================
EXPORTS
============================================================ */

module.exports = {
getJobs,
getJobTitleSuggestions,
Expand Down
Loading