Skip to content

Commit 7f15d6e

Browse files
Merge pull request #4981 from OneCommunityGlobal/Diya_Fix_PeopleReportUI
Diya 🔥 Fixed People Report UI
2 parents 2b37d22 + 5e388be commit 7f15d6e

2 files changed

Lines changed: 19 additions & 15 deletions

File tree

src/components/Reports/PeopleReport/selectors.jsx

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -39,32 +39,36 @@ export const peopleTasksPieChartViewData = (state) => {
3939
const completedUserEntries = allUserEntries.filter(e => e.isActive === true);
4040

4141
const projectHours = {};
42+
const projectNames = {};
43+
4244
allUserEntries.forEach(entry => {
43-
const { projectId } = entry;
44-
if (!projectId) return;
45+
const { projectId, taskId, projectName } = entry;
46+
if (!projectId || taskId) return;
4547
const time = (entry.hours || 0) + (entry.minutes || 0) / 60;
4648
projectHours[projectId] = (projectHours[projectId] || 0) + time;
49+
if (projectName) projectNames[projectId] = projectName;
50+
});
51+
52+
const hoursLoggedToProjectsOnly = Object.entries(projectHours).map(([projectId, totalTime]) => {
53+
const project = (userProjects?.projects || []).find(p => p.projectId === projectId);
54+
return {
55+
projectId,
56+
projectName: project?.projectName || projectNames[projectId] || `Unknown (${projectId.slice(-6)})`,
57+
totalTime,
58+
};
4759
});
4860

49-
const hoursLoggedToProjectsOnly = (userProjects?.projects || []).map(project => ({
50-
projectId: project.projectId,
51-
projectName: project.projectName,
52-
totalTime: projectHours[project.projectId] || 0,
53-
}));
61+
const userTasks = state.userTask?.tasks || [];
5462

5563
const taskHours = {};
56-
completedUserEntries.forEach(entry => {
64+
allUserEntries.forEach(entry => {
5765
if (entry.taskId == null) return;
5866
const taskKey = entry.taskId;
59-
const taskName = entry.taskName || 'Unnamed Task';
67+
const taskName = entry.taskName || `Task in "${entry.projectName || 'Unknown Project'}"`;
6068
const time = (entry.hours || 0) + (entry.minutes || 0) / 60;
6169

6270
if (!taskHours[taskKey]) {
63-
taskHours[taskKey] = {
64-
totalTime: 0,
65-
projectId: entry.projectId,
66-
taskName,
67-
};
71+
taskHours[taskKey] = { totalTime: 0, projectId: entry.projectId, taskName };
6872
}
6973
taskHours[taskKey].totalTime += time;
7074
});

src/components/common/PieChart/ProjectPieChart.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ function CenterLabel({ viewBox, total, darkMode, showPct, onToggle }) {
6868
>
6969
<label className={styles['switch']}>
7070
{/* Accessible text for the label */}
71-
<span className={styles['sr-only']}>Show percentage</span>
71+
{/* <span className={styles['sr-only']}>Show percentage</span> */}
7272

7373
{/* The control associated with the label */}
7474
<input

0 commit comments

Comments
 (0)