Skip to content

Commit 9fdef11

Browse files
Merge pull request #4613 from OneCommunityGlobal/venkataramanan_fix_filter_bio_status_visibility
Venkataramanan fix: filter bio status issue in weekly summary reports page
2 parents 76ff3ab + 9a9fb15 commit 9fdef11

4 files changed

Lines changed: 34 additions & 13 deletions

File tree

src/components/WeeklySummariesReport/FormattedReport.jsx

Lines changed: 23 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -316,8 +316,27 @@ function ReportDetails({
316316
isFinalWeek={isFinalWeek}
317317
/>
318318
</ListGroupItem>
319+
<ListGroupItem darkMode={darkMode}>
320+
<div
321+
style={{
322+
backgroundColor: isMeetCriteria ? '#ffff66' : 'transparent',
323+
width: '100%',
324+
padding: '6px 12px 6px 0px',
325+
}}
326+
>
327+
<Bio
328+
bioCanEdit={bioCanEdit && !cantEditJaeRelatedRecord}
329+
userId={summary._id}
330+
bioPosted={summary.bioPosted}
331+
summary={summary}
332+
getWeeklySummariesReport={getWeeklySummariesReport}
333+
/>
334+
</div>
335+
</ListGroupItem>
336+
337+
{/* TWO-COLUMN CONTENT BELOW */}
319338
<Row>
320-
<Col md="6" xs="12" className="flex-grow-0">
339+
<Col md="6" xs="12">
321340
<ListGroupItem darkMode={darkMode}>
322341
<TeamCodeRow
323342
canEditTeamCode={canEditTeamCode && !cantEditJaeRelatedRecord}
@@ -327,17 +346,6 @@ function ReportDetails({
327346
getWeeklySummariesReport={getWeeklySummariesReport}
328347
/>
329348
</ListGroupItem>
330-
<ListGroupItem darkMode={darkMode}>
331-
<div style={{ backgroundColor: isMeetCriteria ? 'yellow' : 'none' }}>
332-
<Bio
333-
bioCanEdit={bioCanEdit && !cantEditJaeRelatedRecord}
334-
userId={summary._id}
335-
bioPosted={summary.bioPosted}
336-
summary={summary}
337-
getWeeklySummariesReport={getWeeklySummariesReport}
338-
/>
339-
</div>
340-
</ListGroupItem>
341349

342350
<ListGroupItem darkMode={darkMode}>
343351
<TotalValidWeeklySummaries
@@ -346,6 +354,7 @@ function ReportDetails({
346354
darkMode={darkMode}
347355
/>
348356
</ListGroupItem>
357+
349358
<ListGroupItem darkMode={darkMode}>
350359
<p
351360
style={{
@@ -359,10 +368,12 @@ function ReportDetails({
359368
Hours logged: {hoursLogged.toFixed(2)} / {summary.promisedHoursByWeek[weekIndex]}
360369
</p>
361370
</ListGroupItem>
371+
362372
<ListGroupItem darkMode={darkMode}>
363373
<WeeklySummaryMessage summary={summary} weekIndex={weekIndex} />
364374
</ListGroupItem>
365375
</Col>
376+
366377
<Col
367378
xs="6"
368379
style={{

src/components/WeeklySummariesReport/WeeklySummariesReport.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2055,6 +2055,7 @@ const WeeklySummariesReport = props => {
20552055
hasPermissionToFilter={hasPermissionToFilter}
20562056
editable={true}
20572057
formId="report"
2058+
canSeeBioHighlight={permissionState.canSeeBioHighlight}
20582059
/>
20592060
</Col>
20602061
</Row>

src/components/WeeklySummariesReport/WeeklySummariesReport.module.css

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,13 @@
1212
border-color: #fff #dee2e6 #dee2e6;
1313
}
1414

15+
.bioHighlight {
16+
width: calc(100%, 24px);
17+
margin-left: -12px;
18+
margin-right: -12px;
19+
padding: 8px 12px;
20+
}
21+
1522
.reportWrapper {
1623
padding: 20px 0;
1724
margin-top: 5px;

src/components/WeeklySummariesReport/WeeklySummariesToggleFilter.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ export default function WeeklySummariesToggleFilter({
1111
editable,
1212
formId,
1313
hasPermission,
14+
canSeeBioHighlight,
1415
}) {
1516
const handleTrophyToggleChange = () => {
1617
toggleField(setState, 'selectedTrophies');
@@ -66,7 +67,7 @@ export default function WeeklySummariesToggleFilter({
6667
</div>
6768
</div>
6869
)}
69-
{(hasPermissionToFilter || hasPermission?.('highlightEligibleBios')) && (
70+
{(hasPermissionToFilter || canSeeBioHighlight) && (
7071
<div className={`${styles.filterStyle} ml-3`} style={{ minWidth: 'max-content' }}>
7172
<span>Filter by Bio Status</span>
7273
<div className={styles.switchToggleControl}>
@@ -139,4 +140,5 @@ WeeklySummariesToggleFilter.propTypes = {
139140
editable: PropTypes.bool,
140141
formId: PropTypes.string.isRequired,
141142
hasPermission: PropTypes.func,
143+
canSeeBioHighlight: PropTypes.bool,
142144
};

0 commit comments

Comments
 (0)