Skip to content

Commit a1c06d8

Browse files
committed
Fix: Added Grid Lines to the graph
1 parent 191773b commit a1c06d8

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

src/components/BMDashboard/WeeklyProjectSummary/SupplierPerformanceGraph.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,8 @@ const SupplierPerformanceDashboard = function({ height = 420, onDataLoaded }) {
7272
const chartTheme = {
7373
textColor: darkMode ? '#e0e0e0' : '#333',
7474
axisColor: darkMode ? '#a0a0a0' : '#666',
75-
gridColor: darkMode ? '#364156' : '#E2E8F0',
75+
// UPDATE: Set a lighter grey for dark mode so grid lines are clearly visible
76+
gridColor: darkMode ? '#9CA3AF' : '#E2E8F0',
7677
barColor: '#4CAF50',
7778
labelFill: darkMode ? '#ffffff' : '#333',
7879
};
@@ -136,7 +137,6 @@ const SupplierPerformanceDashboard = function({ height = 420, onDataLoaded }) {
136137
{/* Filters Row */}
137138
<div className={styles['supplier-performance-filters']}>
138139
<div className={styles['supplier-performance-filter-group']}>
139-
{/* Linked Label to Input via htmlFor and id */}
140140
<label htmlFor="supplier-date-select">Dates</label>
141141
<Input
142142
id="supplier-date-select"
@@ -154,7 +154,6 @@ const SupplierPerformanceDashboard = function({ height = 420, onDataLoaded }) {
154154
</div>
155155

156156
<div className={styles['supplier-performance-filter-group']}>
157-
{/* Linked Label to Input via htmlFor and id */}
158157
<label htmlFor="supplier-project-select">Project</label>
159158
<Input
160159
id="supplier-project-select"
@@ -188,7 +187,8 @@ const SupplierPerformanceDashboard = function({ height = 420, onDataLoaded }) {
188187
{!loading && !error && supplierData.length > 0 && (
189188
<ResponsiveContainer width="100%" height={height}>
190189
<BarChart data={supplierData} margin={{ top: 20, right: 30, left: 20, bottom: 20 }}>
191-
<CartesianGrid strokeDasharray="3 3" stroke={chartTheme.gridColor} opacity={0.3} />
190+
{/* Added grid lines: Dotted (3 3) and custom theme color */}
191+
<CartesianGrid strokeDasharray="3 3" stroke={chartTheme.gridColor} opacity={0.5} />
192192

193193
<XAxis
194194
dataKey="supplierName"

src/components/BMDashboard/WeeklyProjectSummary/WeeklyProjectSummary.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import OpenIssueCharts from '../Issues/openIssueCharts';
1919
import SupplierPerformanceGraph from './SupplierPerformanceGraph.jsx';
2020
import MostFrequentKeywords from './MostFrequentKeywords/MostFrequentKeywords';
2121
import DistributionLaborHours from './DistributionLaborHours/DistributionLaborHours';
22-
import IssueCharts from '../Issues/openIssueCharts';
2322

2423
const projectStatusButtons = [
2524
{

0 commit comments

Comments
 (0)