Ruike enforce no space in file name#1454
Conversation
sxiong5
left a comment
There was a problem hiding this comment.
Hey @StrawberryCalpico, I have run the Python, and everything looks good. Nice job!
tsunami776
left a comment
There was a problem hiding this comment.
Hi @StrawberryCalpico, I ran the python test you provided for dev and your branch. I found files that not in node_modules now do not have space in their file names. One minor question I wondered is if you can skip checking files in node_modules and .git. Nice work overall!
dev:

Shubhu0
left a comment
There was a problem hiding this comment.
Hi @StrawberryCalpico Tested and reviewed your PR and it is working as intended.
Aishwaryak01
left a comment
There was a problem hiding this comment.
Hi Ruike,
Went through the regex provided in the .gitignore file to remove the space from the filename. It looks good to me. Approved!
|
Thank you all, merging! |
|
Tested alongside Frontend PR #3647, the frontend returns the “Failed to post to LinkedIn” error. |
|
Tested the PR locally and have provided the screenshot in Frontend PR-3647 |








Description
Remove all files with filename contains a white space, and enforce rule by setting .gitignore
Related PRS (if any):
N/A
Main changes explained:
Changed several files' filename, replace ' ' with '_'
add **\ ** in gitignore to ignore changes with whitespace in the filename
How to test:
npm install(optional)Screenshots or videos of changes:
add a new file that contains whitespace in filename


i was using github desktop, make sure there's no local change
Note:
Make sure when run the script, the frontend/backend folder are in the same directory
such as
|| /Github
|| => *.py(replace * with any name)
|| => /frontend
|| => /backend
and run python3 *.py(replace * with any name)