Sai Sandeep taking over for Kristin - Fix Warnings in PeopleTableDetails Unit Tests#3467
Closed
KH07 wants to merge 4 commits intodevelopmentfrom
Closed
Conversation
❌ Deploy Preview for highestgoodnetwork-dev failed.
|
nikhilpittala16
previously approved these changes
May 3, 2025
nikhilpittala16
left a comment
nikhilpittala16
left a comment
There was a problem hiding this comment.
I have tested the PR and everything works as expected.
linkhanthtel
approved these changes
Jun 7, 2025
linkhanthtel
left a comment
linkhanthtel
left a comment
There was a problem hiding this comment.
All test cases passed. Nice work!
one-community
added
the
High Priority - Please Review First
rohanrastogi311
requested changes
Feb 1, 2026
rohanrastogi311
left a comment
rohanrastogi311
left a comment
There was a problem hiding this comment.
Hi Kristin,
Launch Error due to incorrect node version. 14 instead of 20.
one-community
changed the title
Contributor
|
Created new PR to resolve failing test cases. Please follow below link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change data structure usage in PeopleTableDetails.jsx to fix warnings from running unit tests.
Previously, running PeopleTableDetails.test.js would generate a warning message: each child in a list should have a unique "key" prop. The warning is not caused by unit tests code, but indexing in PeopleTableDetails.jsx.
Related PRS (if any):
This frontend PR is related to the #2102 frontend PR and the #3175 frontend PR.
Main changes explained:
How to test:
npm installnpm test PeopleTableDetails.test.jsto run the testsScreenshots or videos of changes:
Note:
Kindly take a look at the code differences and suggest if they impact the feature negatively.