Skip to content

Peterson added improvements to the badge management page#3517

Open
peterson337 wants to merge 5 commits intodevelopmentfrom
peterson-implement-badge-management-darkmode-filter-test
Open

Peterson added improvements to the badge management page#3517
peterson337 wants to merge 5 commits intodevelopmentfrom
peterson-implement-badge-management-darkmode-filter-test

Conversation

@peterson337
Copy link
Copy Markdown
Contributor

Description

This PR was opened to improve the style of the inputs, change the color of the text to white when dark mode is active, and update the text of the button that shows and hides the filters after it is clicked.

Related PRS (if any):

None

Main changes explained:

The BadgeDevelopment.jsx component has been modified to implement the feature.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. Log in as an admin or owner user.
  5. go to Other Links → Badge Management → Badge Development
  6. Activate dark mode and click the button labeled "Add Filters" to display the filters. Check if the text color is white, and if the text of the button that shows and hides the filters changes after being clicked.

Screenshots or videos of changes:

Gif2

Note:

None

@peterson337 peterson337 added the do not review Do not review or look at code without full context label May 13, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented May 13, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit b1f7334
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/6823548c63eb0300081d90d5
😎 Deploy Preview https://deploy-preview-3517--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@peterson337 peterson337 removed the do not review Do not review or look at code without full context label May 13, 2025
Copy link
Copy Markdown
Contributor

@vaibhavkoladiya vaibhavkoladiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the current branch, ran npm install, and cleared site data before logging in as an admin user. Navigated to Other Links → Badge Management → Badge Development, activated dark mode, and tested the "Add Filters" button. Verified that the text color is white and the button label updates correctly when toggled. Everything works as expected — approving the PR.

Screenshot 2025-05-14 163806

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Peterson,

I tried to review your PR locally and was unable to do so cause of node version discrepancy.

Image

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 14, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit cf1b3d7
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69deba0d223e2c000874490b
😎 Deploy Preview https://deploy-preview-3517--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants