Peterson fixed the bug that caused the button to disappear after reloading the page.#3714
Conversation
peterson337
added
the
do not review
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
peterson337
removed
the
do not review
|
This functionality works as intended and the code is great https://www.loom.com/share/fde97e4074f845e6a5c44290bddec7da?sid=384ee371-10da-46c1-ba6b-480486b587a1 |
Babu-kota
left a comment
Babu-kota
left a comment
There was a problem hiding this comment.
Sure! Here's a clear and professional comment you can post on GitHub for PR #3714:
I’ve tested this PR and it resolves the issue as expected. The "Create New Team" button now consistently appears after a page reload when logged in as an admin or owner. No visual or console errors encountered during testing. Nice work on fixing this bug!
adithya-6101
left a comment
adithya-6101
left a comment
There was a problem hiding this comment.
Tested locally as an Admin user. After reloading the Teams page, the “Create New Team” button remains visible as expected. The issue is resolved, and the UI works as intended. Approving this PR.
Neeraj-Kondaveeti
left a comment
Neeraj-Kondaveeti
left a comment
There was a problem hiding this comment.
Logged in as admin and completed the testing. After navigating to the teams page in "Other Links" section and reloading the page , the "Create New Team" button does not disappear. The issue looks resolved. Approving the PR.
rohithmallipudi
left a comment
rohithmallipudi
left a comment
There was a problem hiding this comment.
I’ve tested this PR and can confirm that it resolves the issue as intended. The "Create New Team" button now reliably appears after a page reload when logged in as an admin or owner. Everything functions smoothly, with no visual glitches or console errors during testing. Great job on fixing this bug!
gurusaichittoji7
left a comment
gurusaichittoji7
left a comment
There was a problem hiding this comment.
Everything is perfect & as expected it's working.
aayushshetty12
left a comment
aayushshetty12
left a comment
There was a problem hiding this comment.
'Create New Team' button doesn't disappear after reload. Works right!
|
Please make sure to follow the standard pull request titling please. "Test" isn't very descriptive to detail what happens here |
peterson337
changed the title
|
tested locally using admin user , everything works as expected the button does not disapper after refresh. |
peterson337
dismissed stale reviews from aayushshetty12, Neeraj-Kondaveeti, adithya-6101, and beblicarl
via
72d11d6
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
Thank you all, merging! |
12 participants
Description
This PR has been opened to fix the bug that causes the "Create New Team" button to disappear after reloading the page.
Related PRS (if any):
None
Main changes explained:
The TeamTableSearchPanel.jsx component has been modified to fix the bug.
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Before my fix:
After my fix:
Note:
None