Peterson fixed the bug where the dropdown does not filter the users table#3860
Conversation
peterson337
added
the
do not review
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
peterson337
removed
the
do not review
Namitha7070
left a comment
Namitha7070
left a comment
There was a problem hiding this comment.
After selecting the inactive and pause options, the user table is getting filtered and displaying the correct table. Everything is working as expected.
Recording.2025-08-07.130842.mp4
|
I interacted with the "Show" dropdown, selected different options, and confirmed that the notification message appeared briefly and then disappeared as expected. The users table filtered correctly according to the selected option each time. Everything is working as intended. No issues found. PR_3860.mp4 |
Nahiyan-16
left a comment
Nahiyan-16
left a comment
There was a problem hiding this comment.
Nice work, Peterson! The refactor makes the logic cleaner, especially splitting out updateGetFilteredData for reuse. The table filtering after the "Show" dropdown works as expected now — message displays, disappears, and the results update correctly. Just make sure the extra commas and formatting are consistent throughout for readability.
Recording.2025-08-09.231617.mp4
Naveen-Kumar-Reddy-27
left a comment
Naveen-Kumar-Reddy-27
left a comment
There was a problem hiding this comment.
PR Review Summary:
Checked out the branch and ran npm install successfully.
Cleared cache and logged in as an admin/owner.
Navigated to Other Links → User Management.
Verified the "Show" dropdown: selecting an option displays a temporary message and filters the users table correctly.
Everything is working as expected.
|
This functionality works as intended and the code is great https://www.loom.com/share/db8f5a56a0134dc4814e21b8247923c1?sid=d40813e8-e100-4944-be1a-19dabf5ee7fd |
|
Navigated to Other Links → User Management, selected an option from the Show dropdown, verified that the message displayed and then disappeared after a short time, and confirmed that the users table was correctly filtered based on the selected option. PR3860.mp4
|
|
The PR3860.mp4 |
deep3072
left a comment
deep3072
left a comment
There was a problem hiding this comment.
Reviewed the changes and the message appears when any filter is changed next to "Show" button. It appears on every filter change. The code changes looks good. Approved.
Screen.Recording.2025-09-20.at.23.24.58.mov
peterson337
dismissed stale reviews from beblicarl, Nahiyan-16, and Namitha7070
via
9f8f2b1
peterson337
force-pushed
the
Peterson-fix-the-bug-where-the-dropdown-does-not-filter-the-users-table-2
branch
from
9f8f2b1 to
76c72a6
Compare
…wn-does-not-filter-the-users-table-2
|
9 participants
Description
This PR was opened to fix the bug that prevents the filter from updating the users table on the User Management page.
Related PRS (if any):
None.
Main changes explained:
The UserManagement.jsx component has been modified to fix the bug.
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Before my fix
After my fix
Note:
None.