Skip to content

Neeraj Created a horizontal bar graph comparing the competitiveness of each role#4010

Merged
one-community merged 14 commits intodevelopmentfrom
Neeraj_Job_Posting_Most_Popular_Graph_Frontend
Dec 15, 2025
Merged

Neeraj Created a horizontal bar graph comparing the competitiveness of each role#4010
one-community merged 14 commits intodevelopmentfrom
Neeraj_Job_Posting_Most_Popular_Graph_Frontend

Conversation

@Neeraj-Kondaveeti
Copy link
Copy Markdown
Contributor

@Neeraj-Kondaveeti Neeraj-Kondaveeti commented Sep 3, 2025

image image image

Related PRs (if any):

This frontend PR is related to the Backend OneCommunityGlobal/HGNRest#1693 PR.
It builds on earlier work from PR #3724


Main changes explained:

  • Added a Most Competitive Roles Graph to the dashboard.
  • Implemented role-level aggregation of views and applications.
  • Integrated dark/light mode styling for consistent UI.
  • Added filters for date ranges, roles, and granularity (totals, weekly, monthly, annually).
  • Improved responsive design for small screen widths (< 430px).

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to http://localhost:5173/job-analytics-competitive-roles
  6. verify all features work according to the requirements mentioned in the screenshots above.

Screenshots or Videos of change :

image image image

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 3, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit f1c090d
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/693cdc3f0537cf000860e1df
😎 Deploy Preview https://deploy-preview-4010--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Neeraj-Kondaveeti Neeraj-Kondaveeti added the do not review Do not review or look at code without full context label Sep 3, 2025
@Neeraj-Kondaveeti Neeraj-Kondaveeti added High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible and removed do not review Do not review or look at code without full context High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible labels Sep 4, 2025
Copy link
Copy Markdown
Contributor

@harshavarma29 harshavarma29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR locally using the admin account. The custom dates and date filters are working as expected. However, I noticed the following issues:

  1. Application numbers not clearly visible for some filters:
no_data_visible
  1. Graph is not responsive on smaller screens:
    https://github.com/user-attachments/assets/d23c831b-ad69-4a8c-8091-9a15f2e28c8c

  2. Dark mode not working as expected: Background color does not match the recommended palettes given in the Dark Mode Implementation Guide.

dark_theme_no_working

Recommended dark palettes given in the Darkmode Implementation Guide:
background_color_not_matching

@Neeraj-Kondaveeti
Copy link
Copy Markdown
Contributor Author

I have tested the PR locally using the admin account. The custom dates and date filters are working as expected. However, I noticed the following issues:

  1. Application numbers not clearly visible for some filters:
no_data_visible 2. Graph is not responsive on smaller screens: https://github.com/user-attachments/assets/d23c831b-ad69-4a8c-8091-9a15f2e28c8c 3. Dark mode not working as expected: Background color does not match the recommended palettes given in the [Dark Mode Implementation Guide](https://docs.google.com/document/d/11OXJfBBedK6vV-XvqWR8A9lOH0BsfnaHx01h1NZZXfI/edit?tab=t.0). dark_theme_no_working Recommended dark palettes given in the Darkmode Implementation Guide: background_color_not_matching

Hi Harsha , Hope you are doing well . I have made the necessary changes as requested. Can you please have a look once again and let me know if you see any issues with it.

Thank You for your time and effort.

@Neeraj-Kondaveeti Neeraj-Kondaveeti added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Sep 26, 2025
Aswin20010
Aswin20010 previously approved these changes Oct 21, 2025
Copy link
Copy Markdown

@Aswin20010 Aswin20010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed PR #4010 (Most Competitive Roles Graph Feature) linked to backend PR #1693. Verified addition of role-level aggregation for views and applications, functional date range and granularity filters, and proper dark/light mode styling. Confirmed graph responsiveness on small screens and accurate data rendering under /job-analytics-competitive-roles. No UI or logic regressions observed — approved the PR.

Screenshot 2025-10-21 at 4 44 31 PM Screenshot 2025-10-21 at 4 45 56 PM Screenshot 2025-10-21 at 4 46 24 PM

Copy link
Copy Markdown

@IndraAnuraag9 IndraAnuraag9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR locally using an admin account. the "Most Competitive Roles" Feature is working as intended in both Light and Dark Mode, and is responsive. The data is rendering correctly for all the filter combinations.

Screenshot 2025-10-25 at 9 02 47 PM Screenshot 2025-10-25 at 9 03 48 PM Screenshot 2025-10-25 at 9 04 09 PM

harshavarma29
harshavarma29 previously approved these changes Oct 26, 2025
Copy link
Copy Markdown
Contributor

@harshavarma29 harshavarma29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the PR locally using the Admin account, and the new changes are working as expected. The graph is responsive on smaller screens, dark mode is working as expected, and the application numbers are clearly visible.

new_changes_working_fine.mp4

Anusha-Gali
Anusha-Gali previously approved these changes Nov 22, 2025
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Neeraj,

I have reviewed your PR locally and all the main changes work as expected. I want to highlight a small issue of the white space in dark mode as you can see below of the screenshot.
Screenshot 2025-11-21 at 9 59 42 PM
Screenshot 2025-11-21 at 10 03 40 PM
Screenshot 2025-11-21 at 10 03 47 PM

@sonarqubecloud
Copy link
Copy Markdown

@Neeraj-Kondaveeti Neeraj-Kondaveeti changed the title Neeraj_Created a horizontal bar graph comparing the competitiveness of each role Neeraj Created a horizontal bar graph comparing the competitiveness of each role Dec 13, 2025
@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 0964200 into development Dec 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants