Skip to content

Veda Charitha - Job Specific Template Changes#4026

Open
Charitha2009 wants to merge 11 commits intodevelopmentfrom
veda-job-specific-template-changes
Open

Veda Charitha - Job Specific Template Changes#4026
Charitha2009 wants to merge 11 commits intodevelopmentfrom
veda-job-specific-template-changes

Conversation

@Charitha2009
Copy link
Copy Markdown
Contributor

@Charitha2009 Charitha2009 commented Sep 6, 2025

Description

Screenshot 2026-03-12 at 11 14 37 PM

Related PRS (if any):

This frontend PR is related to the development backend PR.

Main changes explained:

  • Job-aware application form: Full fields + engineering-only questions, basic validation/toasts, and a “Learn more” link that opens the modal.
  • Refactored job modal: Full-width “Seeking Experienced {Job Title}” → One Community intro → description with auto-built sections; keeps image grid + external details link; close (×) inside card.
  • Polish & consistency: Helpers normalize ad data; updated CSS (stacked header, chips, spacing, responsive/dark-mode); consistent “Select a position” placeholder and immediate form on selection.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to http://localhost:5173/collaboration/analytics
  6. Select a job From dropdown: Verify the ApplicationForm renders with additional fields and, for engineering and other roles.
  7. Learn more link: At the bottom of the form, click Learn more about this position → modal opens.
    Confirm: If it opens job description modal in brief.

Screenshots or videos of changes:

Screenshot 2025-09-05 at 8 09 34 PM Screenshot 2025-09-05 at 8 09 49 PM Screenshot 2025-09-05 at 8 10 05 PM Screenshot 2025-09-05 at 8 10 26 PM

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 6, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 3b5a74f
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/68bb7c8b4d1a0a00089d54d7
😎 Deploy Preview https://deploy-preview-4026--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hemanthvenkat
Copy link
Copy Markdown

Verified this PR by selecting a job from the dropdown and confirming the ApplicationForm renders with additional fields for engineering and other roles.
Checked the Learn more link at the bottom, which opened the job description modal.
All functionality worked as expected without issues.

PR4026.mp4

SudheeshTD
SudheeshTD previously approved these changes Sep 10, 2025
Copy link
Copy Markdown
Contributor

@SudheeshTD SudheeshTD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Job Specific template page displays all the additional fields, and it shows job description at the end of the page and all the other details properly renders.
image
image
image

image

@Charitha2009 Charitha2009 changed the title Job Specific Template Changes Veda Charitha - Job Specific Template Changes Sep 19, 2025
akshith312
akshith312 previously approved these changes Sep 20, 2025
Copy link
Copy Markdown
Contributor

@akshith312 akshith312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR locally. Logged in as Admin user.
Forms are working as expected and are responsive as well.

image image image image

Copy link
Copy Markdown
Contributor

@Prem203 Prem203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the PR with an admin account. The form renders correctly when a job is selected. The card pops up correctly with brief description when clicked on the link.

However in dark mode, the form itself is dark but the background still remains white. The colors in dark mode for title and questions makes it difficult to read, while the numbers are not visible.

image image image image

Copy link
Copy Markdown

@Swetha-1306 Swetha-1306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR. Everything works as described including the link for specific job description depending on the job user chooses.
Pasted Graphic 1
Pasted Graphic 2
Seeking Experienced Experienced MERN Stack

@IndraAnuraag9
Copy link
Copy Markdown

Tested this PR locally, with an Owner Account. Everything is working as it is intended to, and the form is responsive.
However in dark mode, the form itself is dark but the background remains white.

Screenshot 2025-10-02 at 8 46 32 PM Screenshot 2025-10-02 at 8 46 36 PM Screenshot 2025-10-02 at 8 46 40 PM Screenshot 2025-10-02 at 8 46 57 PM

Copy link
Copy Markdown
Contributor

@harshavarma29 harshavarma29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the PR using the Admin account, and the job filters are working as expected. However, I noticed the following issues:

  1. Dark mode issue: The dark theme does not cover the entire UI, and some UI elements are not changing properly in dark mode.
    dark_mode_issue

  2. Job cards in the "Show Summaries" tab do not have a fixed size:
    https://github.com/user-attachments/assets/6f01d2c3-938a-45c1-a1bc-df8c1770f1bd

  3. Page responsiveness issue: The page is not responsive between 640px and 1030px:
    https://github.com/user-attachments/assets/198437e7-77bc-4505-8668-dbd9086a3a8f

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Nov 7, 2025
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Charitha,

I have reviewed your PR locally and have identified the below issues.

  1. When we click back, the texts used to search for the job should be cleared out
  2. The dark mode is not enabled for the text in the form as well as modal popup
Screenshot 2025-11-21 at 8 22 38 PM Screenshot 2025-11-21 at 8 22 52 PM Screenshot 2025-11-21 at 8 23 19 PM Screenshot 2025-11-21 at 8 23 22 PM **Issue 1: When we click back, the texts used to search for the job should be cleared out** Screenshot 2025-11-21 at 8 23 45 PM Screenshot 2025-11-21 at 8 23 59 PM **Issue 2: The dark mode is not enabled for the text in the form as well as modal popup** Screenshot 2025-11-21 at 8 24 26 PM Screenshot 2025-11-21 at 8 24 32 PM

Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Veda, well done with the implementations. One big issue is the job description isn't showing properly (check image below)

PR 4026 Screenshot PR 4026 Screenshot 2 PR 4026 Screenshot 3 PR 4026 Screenshot 4

- Take Collaboration.jsx and yarn.lock from development
- Remove legacy Collaboration.css; keep rest of branch changes

Made-with: Cursor
@Charitha2009 Charitha2009 dismissed stale reviews from akshith312 and SudheeshTD via 792251d March 13, 2026 02:48
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 13, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 75c2e8f
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69e800b68a3da2000876eb5d
😎 Deploy Preview https://deploy-preview-4026--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Test added 2 commits March 12, 2026 23:10
…ion cards

- Add react-router history navigation from Collaboration cards to /job-application
- Pass jobId, title, description, requirements, and category in location.state
- Remove legacy modal so job details are handled by JobApplicationForm page

Made-with: Cursor
- Collaboration: center container, responsive job grid spacing
- JobApplicationForm: balanced header bar (job title, Go, dropdown) attached to form

Made-with: Cursor
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Veda,

Thanks for fixing the issue i had previously mentioned, however new issues popped up.

  • The calendar in dark mode is in light mode
  • Also the description is not visible anymore
Image Image

Issues
Image
Image
Image

Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Veda,

Job descriptions are not showing. Well done on previous fixes though!

Image Image

rohanrastogi311

This comment was marked as duplicate.

Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Veda,

The calendar is appearing in light mode even when the application is in dark mode. Additionally, the description is displayed incorrectly and the questions text is not visible in dark mode, and the Enter Job Title field is also appearing in light mode.

Image Image Image

Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Veda Charitha,

The calendar, description, and Enter Job Title field issues in dark mode are rectified. However, the questions are still repeating and the dropdown for question ("Will your volunteer time require documentation of your hours?") is not properly sized. Please check once

Image Image Image

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Veda,

Thanks for fixing the previous issues, however need your fixes on:

  • The questions are repeating, due to which few questions do not have text box or the upload button, also Q8 on top and Q7 on bottom are not similar to the rest of the Questions UI.
  • As you can see in the video attached, no matter which role i select, the form is redirected towards "Virtual Assistant".
Image Image Image
4026.mp4

Test added 3 commits April 11, 2026 14:47
Resolve Collaboration.jsx: combine React hooks with useHistory; remove
obsolete fetchPositions that referenced removed setPositions.

Resolve Collaboration.module.css: keep branch card styling with modern
color notation.

Made-with: Cursor
…e questions

Use location.state.jobTitle to select the correct form when coming from job
listings. Remove hardcoded Q1–8 that duplicated API questions and broke
answer indices. Normalize questionType (textbox, etc.), filter visible
questions, and align date/dropdown/textarea styling. Stylelint fixes.

Made-with: Cursor
Use history push with search query so job title survives navigation. Add
bannerJobTitle for FORM FOR … heading; improve form title fuzzy matching.
Modal uses banner title for category and display.

Made-with: Cursor
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Veda,

Thank you for fixing the previous errors, just one small UI issue - the numbers are visible twice in the form, do have a look at it. The rest of the functionality works as per requirement.

Issue
Image
Image

Issues Fixed
Image
Image
Image

Strip embedded template enumeration (e.g. "1.)") when rendering numbered headings.

Made-with: Cursor
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.