Skip to content

Deep fix volunteer status pie chart#4138

Merged
one-community merged 10 commits intodevelopmentfrom
deep-fix-volunteer-status-pie-chart
Dec 9, 2025
Merged

Deep fix volunteer status pie chart#4138
one-community merged 10 commits intodevelopmentfrom
deep-fix-volunteer-status-pie-chart

Conversation

@deep3072
Copy link
Copy Markdown
Contributor

Description

Added a new pie chart to show Total Mentors next to Total Volunteer pie chart

Screenshot 2025-09-27 at 23 25 34

Related PRS (if any):

This frontend PR is related to the #1759 backend PR.

Main changes explained:

  • Added a mentor-status pie chart that consumes mentorNumberStats and renders next to the volunteer chart with the shared footnote.
  • Built externalLabelGuidesPlugin.js to draw connector lines and pill-shaped callouts
  • Tweaked chart CSS (heading centering, count offset, container spacing) so the volunteer and mentor pie charts stay visually aligned.

How to test:

  1. Checkout to deep-fix-volunteer-status-pie-chart branch in the frontend.
  2. Checkout to deep-fix-volunteer-status-pie-chart branch in backend and run it to test.
  3. Run npm install, and ... to run this PR locally.
  4. Clear site data/cache.
  5. Log in as Admin user.
  6. Go to dashboard→ Reports→ Total Org Summary
  7. Verify if the Total Mentors Chart is properly loaded or not.
  8. Verify the count is changing as per date filters.

Screenshots or videos of changes:

Before:

Screen.Recording.2025-09-28.at.14.46.46.mov

After:

Screen.Recording.2025-09-28.at.14.41.37.mov

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 28, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 3d46c29
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69363fc42a15b60008ed5c57
😎 Deploy Preview https://deploy-preview-4138--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Oct 1, 2025
@hemanthvenkat
Copy link
Copy Markdown

PR verification confirms the Total Mentors Chart loads correctly under Total Org Summary. The mentor count updates accurately based on applied date filters.
https://github.com/user-attachments/assets/0d4a263a-56a7-4693-9544-3959d15ace32

Copy link
Copy Markdown

@laharinandipati laharinandipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its working as expected.
Screenshot 2025-10-03 at 11 17 55 AM

laharinandipati
laharinandipati previously approved these changes Oct 3, 2025
Copy link
Copy Markdown

@laharinandipati laharinandipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the concerned backend and frontend PRs. Working as expected
Screenshot 2025-10-03 at 11 17 55 AM

@ChiragBellara
Copy link
Copy Markdown
Contributor

Reviewed PR #4138
The page loads and displays the pie chart as expected. The pie chart also reflects the change in values on applying a date filter.
Pie Chart works as expected

However, I noticed that there is a time delay between the application of the date filter and it's reflection on the charts. This seems to happen on all the visualizations on the screen. I suggest adding a loading animation to the chart to ensure that it is not confusing to the users.

Delay.between.application.of.filter.and.its.reflection.on.the.charts.mov

laynet
laynet previously approved these changes Oct 3, 2025
Copy link
Copy Markdown

@laynet laynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed PR #4138. I followed the testing instructions and logged in as admin user running the backend with PR # 1759. The graph loaded as expected and changed when different dates were selected through the filters. Behaved as expected in dark mode as well. There was a significant lag between filter selection and graph load.
PR 4138 date range
PR 4138 chart load

akshith312
akshith312 previously approved these changes Oct 3, 2025
Copy link
Copy Markdown
Contributor

@akshith312 akshith312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested PR locally. Logged in as Admin.
All the charts are rendering as expected.

image image image

Ramaruva
Ramaruva previously approved these changes Oct 7, 2025
Copy link
Copy Markdown
Contributor

@Ramaruva Ramaruva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, changes are working as expected

Image

KurtisIvey
KurtisIvey previously approved these changes Oct 11, 2025
Copy link
Copy Markdown
Contributor

@KurtisIvey KurtisIvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and functions as intended. it does look like there's some merge conflicts that need to be sorted out though

Screenshot 2025-10-11 at 2 41 11 PM

Charts are visually balanced. Approved!

Aswin20010
Aswin20010 previously approved these changes Oct 16, 2025
Copy link
Copy Markdown

@Aswin20010 Aswin20010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the new Mentor Status Pie Chart under Reports → Total Org Summary. Verified data rendering from mentorNumberStats, correct alignment beside the volunteer chart, and consistent count updates based on date filters. Confirmed the connector lines and pill-shaped callouts render correctly using externalLabelGuidesPlugin.js. Checked layout spacing, responsiveness, and dark mode — all functioning as expected. Approved the Frontend and related Backend PR.

Screenshot 2025-10-16 at 12 56 35 PM Screenshot 2025-10-16 at 12 59 14 PM

Copy link
Copy Markdown
Contributor

@Aditya-gam Aditya-gam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The mentor chart follows the same architectural pattern as the volunteer chart, ensuring consistency
  • Props are properly typed with PropTypes validation
  • Responsive design implementation with appropriate loading states
  • The mentor donut chart renders correctly alongside the volunteer chart
  • Clean separation of concerns with dedicated components for each chart
Image

These are the issues I found:

  • The floating labels disappear when positioned near the chart boundaries. The externalLabelGuidesPlugin calculates label positions but doesn't account for container overflow, causing labels to be clipped when they extend beyond the chart container's bounds.
Image
  • The chart headings ("TOTAL VOLUNTEERS" and "TOTAL MENTORS") use hardcoded colors (#828282 and #6c6c6c) that don't adapt to dark mode. These colors remain dark gray in dark mode, making them difficult to read against the dark background.
Image
  • The charts are clipped on smaller screens, particularly:
    • iPad Pro dimensions (1024px × 1366px)
    • Screen widths between 992.50px x 1025px to 1390px x 1025px
  • The current CSS uses fixed flex values and doesn't properly handle the container width constraints for these breakpoints.
Image

Test Video:

TestVideo.mov

@deep3072 deep3072 dismissed stale reviews from KurtisIvey, Ramaruva, and laynet via b0f91fe October 17, 2025 16:54
@sonarqubecloud
Copy link
Copy Markdown

Aditya-gam
Aditya-gam previously approved these changes Oct 18, 2025
Copy link
Copy Markdown
Contributor

@Aditya-gam Aditya-gam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested the new changes on the local environment.
  • The labels now don't overflow and are properly visible.
UpdatedLabels
  • The chart headings ("TOTAL VOLUNTEERS" and "TOTAL MENTORS") now appropriately adapt to dark mode.

    UpdatedDarkmode
  • The charts are now responsive for smaller screen sizes.

UpdatedIpadScreen
  • Checked for multiple screen sizes, including the ones mentioned in the first review. The Charts are now responsive for all screen sizes.

Test Video:

UpdatedTestVideo.mov

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 8, 2025

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 202b2a9 into development Dec 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.