Skip to content

Bhavpreet: listing bidding dashboard demand chart#4172

Merged
one-community merged 21 commits intodevelopmentfrom
bhavpreet_lb_demand_chart
Dec 13, 2025
Merged

Bhavpreet: listing bidding dashboard demand chart#4172
one-community merged 21 commits intodevelopmentfrom
bhavpreet_lb_demand_chart

Conversation

@fangedShadow
Copy link
Copy Markdown
Contributor

Description

Added the demand charts
Screenshot 2025-10-04 221346

Or Implements # (WBS)

Related PRS (if any):

checkout to this branch and the development branch in the backend

Main changes explained:

  • Added the worlCLoud charts

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to dashboard→ /lbdashboard
  6. Follow the video
  7. verify this new feature works in dark mode

Screenshots or videos of changes:

###Video of the feature

Screen.Recording.2025-10-04.222647.mp4

Note:

Include the information the reviewers need to know.

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 5, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 9432302
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/693bb18f92e35300083df98c
😎 Deploy Preview https://deploy-preview-4172--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fangedShadow fangedShadow changed the title Bhavpreet lb demand chart Bhavpreet: listing bidding dashboard demand chart Oct 5, 2025
@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Oct 18, 2025
@hemanthvenkat
Copy link
Copy Markdown

PR verified end-to-end: UI flows work as expected and CSS is consistent, responsive, and theme-aware (light/dark parity). Disabled/active states, toasts, charts, and maps render correctly with proper spacing, typography, and contrast; no layout shifts or console errors observed. Overall, no visual regressions—behavior and styling meet the spec.
https://github.com/user-attachments/assets/03ce211d-c2c5-45b5-85e5-a45f56d0a4f2

Copy link
Copy Markdown
Contributor

@Aditya-gam Aditya-gam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested this PR following the instructions in the PR description.
  • The charts work correctly in dark and light modes.
  • The filters modify the charts according to the selections made.
  • In the dark mode, in the filters section, the Current Metric's value and the Choose metric title are not readable.
TestVideo.mov

@fangedShadow
Copy link
Copy Markdown
Contributor Author

  • Tested this PR following the instructions in the PR description.
  • The charts work correctly in dark and light modes.
  • The filters modify the charts according to the selections made.
  • In the dark mode, in the filters section, the Current Metric's value and the Choose metric title are not readable.

TestVideo.mov

the readble issue that you mention is not the part of the pr, the pr is suppose to be for the charts

@sanjeev29
Copy link
Copy Markdown
Contributor

sanjeev29 commented Oct 20, 2025

Tested the PR changes. The graph is dynamic with the given filters and works both in light and dark mode. The current metric is not readable in dark mode.
Screenshot 2025-10-20 at 2 50 54 PM
Screenshot 2025-10-20 at 2 53 07 PM

Aswin20010
Aswin20010 previously approved these changes Oct 20, 2025
Copy link
Copy Markdown

@Aswin20010 Aswin20010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed PR #4172 (Word Cloud Charts Addition). Verified the new Word Cloud visualization renders correctly under /lbdashboard, functions in dark mode, and aligns with existing dashboard styling. Confirmed chart responsiveness, data rendering, and no UI or performance regressions — approved the PR.

Screenshot 2025-10-20 at 4 20 18 PM Screenshot 2025-10-20 at 4 20 30 PM Screenshot 2025-10-20 at 4 20 43 PM

Aditya-gam
Aditya-gam previously approved these changes Oct 20, 2025
Copy link
Copy Markdown
Contributor

@Aditya-gam Aditya-gam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested this PR following the instructions in the PR description.
  • The charts work correctly in dark and light modes.
  • The filters modify the charts according to the selections made.
TestVideo.mov

@apoorvajainrp21
Copy link
Copy Markdown
Contributor

Reviewed the PR changes, everything works as expected. The graphs are dynamic.
image

@tomkkl
Copy link
Copy Markdown

tomkkl commented Oct 23, 2025

Hello,

Since others have tested with Dark Mode above, I have tested with light mode instead and can confirm working.

Screenshot 2025-10-23 at 1 31 16 AM

@sonarqubecloud
Copy link
Copy Markdown

@Vinay944924
Copy link
Copy Markdown
Contributor

Hi Bhavpret,
I tested the PR locally logged in as a owner account and Graph seems fine and the UI working is also working fine. It even worked fine in dark mode. I have uploaded the screenshots below
Screenshot 2025-11-01 at 7 27 04 PM
Screenshot 2025-11-01 at 7 27 10 PM
Screenshot 2025-11-01 at 7 27 19 PM
Screenshot 2025-11-01 at 7 27 24 PM

@ManeeshBuddha21
Copy link
Copy Markdown

Hi Bhavpreet,
I tested this PR locally while logged in as an Owner account. The graph displays correctly, and the UI functions smoothly. It also works well in dark mode. I’ve uploaded the screenshots below for reference.

localhost_5173_LBdashboard localhost_5173_LBdashboard (1)

Sriamshreddy000
Sriamshreddy000 previously approved these changes Nov 5, 2025
Copy link
Copy Markdown
Contributor

@Sriamshreddy000 Sriamshreddy000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

I have reviewed by following the instructions, logged in as an admin user. The /Ibdashboard page works, graph changes smoothly and accordingly to every selected data labels. Works both in dark mode and light mode. I have attached screenshot for reference

Screenshot 2025-11-04 at 7 34 26 PM

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Bhavpreet,

I have reviewed your PR locally, though the functionality works as expected in both light and dark mode. I did identify a UI issue : As you can see in both the charts below the highest value is getting trimmed off the higher the graph goes in the chart (Could be due to the are around the chart title). Please look into it.
Screenshot 2025-11-08 at 10 39 44 PM

Screenshot 2025-11-08 at 10 38 51 PM

Copy link
Copy Markdown
Contributor

@smohansatyaram smohansatyaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Bhavpreet, I tested this PR locally and reviewed the demand charts on the LB Dashboard. The charts render smoothly, respond to the filter selections, and work correctly in both light and dark modes. The transitions between datasets look good and the feature behaves as expected. I did notice that the top values on the charts appear slightly clipped when the graph peaks, so it may help to adjust the padding or margin above the chart area. Other than that, the implementation looks solid.

image image image

Copy link
Copy Markdown

@Raghu04122002 Raghu04122002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Bhavpreet,
I tested the PR by running locally as a admin user. The charts displayed are perfectly fine and the filter feature is working as expected.

PR4712 PR41271

Copy link
Copy Markdown
Contributor

@bhanuanishakkineni bhanuanishakkineni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Bhavpreet,
I have checked this PR and tested all the new requirements through logged in in as admin.
The UI is working fine and responsive
Charts are working fine and are dynamic an smooth.
And current metrics are clearly displayed
All the above features are working fine in both light and dark modes.

PR.4172.testing.mp4

debadyuti23
debadyuti23 previously approved these changes Dec 7, 2025
Copy link
Copy Markdown

@debadyuti23 debadyuti23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Bhavpreet I have reviewed your changes, all the dashboards, features render correctly as shown in the video.

PR_4172.mp4

Copy link
Copy Markdown

@VijayAnirudh VijayAnirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image This is probably due to the dependency conflict. Let me know if you want me to test it by installing legacy peer dependencies!

@SwathiAngadi
Copy link
Copy Markdown
Contributor

SwathiAngadi commented Dec 10, 2025

Hi Bhavpreet,

Tested your PR. All the charts are loading perfectly with various options. Transition is smooth. One small thing noticed here is , in Dark mode the selected dropdown like Demand or Vacancy is not highlighted as it is highlighted in Light mode, only the dropdown icon is highlighted in Dark mode. Rest everything looks good.

Screen.Recording.2025-12-10.120552.mp4

@fangedShadow fangedShadow dismissed Anusha-Gali’s stale review December 11, 2025 14:40

the isssue that you mention is very rare, although i have added extra padding on top

@sonarqubecloud
Copy link
Copy Markdown

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 95bf4d2 into development Dec 13, 2025
10 checks passed
Copy link
Copy Markdown

@Vikas-8055 Vikas-8055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the PR locally by logging in as an admin user. The /lbdashboard page functions as expected t
Screenshot 2026-01-16 at 9 59 29 PM
Screenshot 2026-01-16 at 9 59 22 PM
he graphs update smoothly and respond correctly to all selected data label filters.

Copy link
Copy Markdown
Contributor

@Shravan-neelamsetty Shravan-neelamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Bhavpreet,
i have tested this pr locally and tested the functionality in dark mode mode as well and everything works well.
Screenshot 2026-01-17 at 2 35 39 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.