Prem UI overlapping issue#4239
Conversation
…ighestGoodNetworkApp into Prem-UI-overlapping-issue
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Aswin20010
left a comment
There was a problem hiding this comment.
Reviewed PR #4239(Community Portal Dashboard UI Alignment Fix). Verified updated alignment adjustments in CPDashboard.jsx. Checked layout consistency under search filters and overall visual stability. No UI or functional regressions found — approved the PR.
Aditya-gam
left a comment
There was a problem hiding this comment.
This PR successfully addresses UI alignment issues in the Community Portal dashboard through a well-executed migration to CSS Modules. The conversion from CPDashboard.css to CPDashboard.module.css follows React best practices for style encapsulation, preventing class name conflicts in the larger application.
- All className references correctly updated to bracket notation (
styles['class-name']) - Added
filter-section-dividerwrapper with flexbox layout to resolve the filter section alignment issue - Removed
fluidprop from Container, improving layout constraints with explicitmax-width: 1400px - Consistent formatting improvements (multi-line img attributes)
TestVideo.mov
Concerns:
- The CSS file contains global
bodystyles, which defeats CSS Module scoping benefits - Some commented-out CSS properties (
/* margin-bottom: 20px; */) should be removed for cleaner code
There was a problem hiding this comment.
Hi Prem,
I have reviewed your PR locally and all filter options (Dates, Online, Branches, Themes, Categories) render properly with functional dropdowns and calendar input. Layout, contrast, and alignment look consistent across the interface. But None of the drop-down buttons present various options on selection, similarly there is no change in events after changing filters nor the past events button does anything. Since this is a UI PR i will be approving but a bit more functionality would have been great.
https://github.com/user-attachments/assets/5ff08604-8d87-4b27-b9a5-cfdf85d75669
5d4b5bc
|
Thank you all, merging! |
|







Description
Related PRS (if any):
This frontend PR is not related to any backend PR.
…
Main changes explained:
…
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Note:
Dark mode was not specified in the description.