Skip to content

Xinyi - fix: longst open issues chart#4301

Merged
one-community merged 2 commits intodevelopmentfrom
xinyi_fix_longest_open_issues_chart
Dec 6, 2025
Merged

Xinyi - fix: longst open issues chart#4301
one-community merged 2 commits intodevelopmentfrom
xinyi_fix_longest_open_issues_chart

Conversation

@RitzzzZ2021
Copy link
Copy Markdown
Contributor

@RitzzzZ2021 RitzzzZ2021 commented Oct 31, 2025

Description

image

Related PRS (if any):

#3660 + #1463

Main changes explained:

  • Update file issueChart.module.css to fix text overlap and visibility issues
  • Update file openIssueCharts.jsx to use the updated styles and process data

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to dashboard→ Reports -> Total Construction Summary -> Issue Tracking
  6. verify the date filter and project filter work properly
  7. verify there is no text overlap, and all data is visible
  8. verify this new feature works in dark mode

Screenshots or videos of changes:

before:
image

after:
image

Note:

Include the information the reviewers need to know.

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 31, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 580f04c
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69324d6e3c66ff0008b13019
😎 Deploy Preview https://deploy-preview-4301--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@RitzzzZ2021 RitzzzZ2021 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Nov 9, 2025
Copy link
Copy Markdown
Contributor

@Aditya-gam Aditya-gam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I followed the provided test plan (fresh install, cache cleared, logged in as owner) to verify this PR. The changes successfully address the text overlap and visibility issues described in the PR.
Image
  • Date Range Filter: Works correctly and allows users to select start and end dates.
  • Projects Filter: Functions correctly with multi-select capability and includes a reset button to clear all selected projects.
  • Text Overlap: The text overlap issue has been resolved. All chart data and labels are now clearly visible without overlapping.
  • Responsive Design: The page is responsive and adapts well to smaller screen sizes, with labels appropriately hidden on mobile devices as designed.

Issues Identified:

  1. Missing Projects Filter Label: The projects filter dropdown lacks a visible label, which reduces clarity about what the filter controls. Consider adding a label similar to the date range filter (e.g., "Projects:").

  2. Date Range Reset Functionality: The projects filter includes a reset button to clear all selections, but the date range filters do not have a similar clear/reset mechanism. For consistency and better UX, consider adding clear buttons or an isClearable prop to the DatePicker components.

  3. Dark Mode Visibility Issues:

  • Date Range Labels: The "From" and "To" labels are not clearly visible in dark mode. The CSS includes a .dark .dateLabel selector (line 70), but the component uses conditional class application rather than a parent .dark class, so this styling is not being applied.
Image
  • React-Select Dropdown Styling: The dropdown menu items in the projects filter are not readable in dark mode. The current implementation only applies a selectDark class, which doesn't properly style the dropdown menu, options, or other React-Select components.
Image
  • The migration from global CSS to CSS modules is an improvement for maintainability. Using useMemo for data normalization is appropriate for performance optimization. The responsive grid layout implementation is clean and well-structured.

  • Test Video:

TestVideo.mov

Overall Assessment:
The PR successfully resolves the primary text overlap and visibility issues in light mode. However, the dark mode styling needs attention to ensure all UI elements are clearly visible and accessible. The suggested improvements would enhance consistency with other components in the codebase and improve the user experience across both light and dark themes.

@RitzzzZ2021
Copy link
Copy Markdown
Contributor Author

  • I followed the provided test plan (fresh install, cache cleared, logged in as owner) to verify this PR. The changes successfully address the text overlap and visibility issues described in the PR.
Image * **Date Range Filter**: Works correctly and allows users to select start and end dates. * **Projects Filter**: Functions correctly with multi-select capability and includes a reset button to clear all selected projects. * **Text Overlap**: The text overlap issue has been resolved. All chart data and labels are now clearly visible without overlapping. * **Responsive Design**: The page is responsive and adapts well to smaller screen sizes, with labels appropriately hidden on mobile devices as designed.

Issues Identified:

  1. Missing Projects Filter Label: The projects filter dropdown lacks a visible label, which reduces clarity about what the filter controls. Consider adding a label similar to the date range filter (e.g., "Projects:").
  2. Date Range Reset Functionality: The projects filter includes a reset button to clear all selections, but the date range filters do not have a similar clear/reset mechanism. For consistency and better UX, consider adding clear buttons or an isClearable prop to the DatePicker components.
  3. Dark Mode Visibility Issues:
  • Date Range Labels: The "From" and "To" labels are not clearly visible in dark mode. The CSS includes a .dark .dateLabel selector (line 70), but the component uses conditional class application rather than a parent .dark class, so this styling is not being applied.
Image * React-Select Dropdown Styling: The dropdown menu items in the projects filter are not readable in dark mode. The current implementation only applies a `selectDark` class, which doesn't properly style the dropdown menu, options, or other React-Select components. Image * The migration from global CSS to CSS modules is an improvement for maintainability. Using `useMemo` for data normalization is appropriate for performance optimization. The responsive grid layout implementation is clean and well-structured. * **Test Video:**

TestVideo.mov
Overall Assessment: The PR successfully resolves the primary text overlap and visibility issues in light mode. However, the dark mode styling needs attention to ensure all UI elements are clearly visible and accessible. The suggested improvements would enhance consistency with other components in the codebase and improve the user experience across both light and dark themes.

Thank you Aditya, for the detailed review. I've modified the code to address all the problems you caught. Please review it again and see if the problems are solved.
image

@RitzzzZ2021 RitzzzZ2021 force-pushed the xinyi_fix_longest_open_issues_chart branch from b9dcebd to 580f04c Compare December 5, 2025 03:11
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 5, 2025

@Aditya-gam Aditya-gam self-requested a review December 5, 2025 22:14
Copy link
Copy Markdown
Contributor

@Aditya-gam Aditya-gam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the new changes.

  1. The dark mode UI issues are now solved.
Image
  1. The Projects selector now has a label.
Image
  1. The Date Range filters now have individual reset buttons.
Image

All the functionality works correctly.

Copy link
Copy Markdown
Contributor

@bhanuanishakkineni bhanuanishakkineni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed and tested this PR through logging as an admin and directing to total Construction summary page.
I tested the longest open issues chart through following steps:
Project filter: Was able to select single and multiple projects as filters and was able to clear filter easily.
Date filter: Able to pick start date and end date between which I wish to see the issues. Also able to clear the date filters.
For all the filters and no filters, there is no text overlap and the data is visible clearly and is readable.
Even during the dark mode, the chart is functional and the text and the data are readable.
Finally, the page is responsive for all screen sizes in both light and dark mode without any overlaps and data readability.

PR.4301.testing.mp4

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 4b04a21 into development Dec 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants