Skip to content

Xinyi - fix: dropdown and issue data fetching#4385

Open
RitzzzZ2021 wants to merge 2 commits intodevelopmentfrom
xinyi_fix_dropdown_issue
Open

Xinyi - fix: dropdown and issue data fetching#4385
RitzzzZ2021 wants to merge 2 commits intodevelopmentfrom
xinyi_fix_dropdown_issue

Conversation

@RitzzzZ2021
Copy link
Copy Markdown
Contributor

@RitzzzZ2021 RitzzzZ2021 commented Nov 14, 2025

Description

FIXES BOTH OF THESE PHASE 2 ISSUES:
image

Related PRS (if any):

None.

Main changes explained:

  • Update file IssueDashboard.jsx to fix data fetch issue.
  • Update file Header.jsx to fix routing of "Issue" page in the dropdown menu.
  • Update file ProjectDetails.jsx to fix data fetch issue.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to http://localhost:5173/bmdashboard/projects/67f0cc5987814ffa08fcfac7
  6. verify that the dropdown menu Projects -> Issue redirects to the issue page
  7. verify routing consistency with the standalone “View Issues” buttons
  8. verify this new feature works in dark mode

Screenshots or videos of changes:

fix_dropdown_issue.mov

Note:

Include the information the reviewers need to know.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 14, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 3be28b4
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69388f4b9c85830008e67bc8
😎 Deploy Preview https://deploy-preview-4385--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@RitzzzZ2021 RitzzzZ2021 changed the title Xinyi - fix: dropdown issue Xinyi - fix: dropdown and issue data fetching Nov 17, 2025
Aditya-gam
Aditya-gam previously approved these changes Nov 20, 2025
Copy link
Copy Markdown
Contributor

@Aditya-gam Aditya-gam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I followed the provided test plan (fresh install, cache cleared, logged in as owner) to verify this PR.
  • The Projects dropdown menu correctly routes to the issues page and successfully loads the page.
  • The View Issues button also redirects to the same issues page.
  • Both the pages work correctly in dark mode.
  • One issue I see is when I go to the issues page and click the Back to projects button, I get a "Page not Found" error.
TestVideo.mov

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 9, 2025

@RitzzzZ2021
Copy link
Copy Markdown
Contributor Author

  • I followed the provided test plan (fresh install, cache cleared, logged in as owner) to verify this PR.
  • The Projects dropdown menu correctly routes to the issues page and successfully loads the page.
  • The View Issues button also redirects to the same issues page.
  • Both the pages work correctly in dark mode.
  • One issue I see is when I go to the issues page and click the Back to projects button, I get a "Page not Found" error.

TestVideo.mov

Thank you for catching the issue on the issues page. I've fixed the problem and conflicts with development branch. Please review the file changes.

I noticed that the development branch introduces some styling issues. Please dismiss those for this PR and check the logic of the buttons.

@beblicarl
Copy link
Copy Markdown
Contributor

This functionality works as intended and the code is great

https://www.loom.com/share/8e43e5138d324574996fb55f7525f1bd

@beblicarl beblicarl self-requested a review December 26, 2025 14:42
@one-community one-community added Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. do not review Do not review or look at code without full context labels Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not review Do not review or look at code without full context Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants