Skip to content

Aayush lessons learned hover ghost bar graph#4461

Merged
one-community merged 4 commits intodevelopmentfrom
aayush_lessons_learned_hover_ghost_bar_graph
Apr 3, 2026
Merged

Aayush lessons learned hover ghost bar graph#4461
one-community merged 4 commits intodevelopmentfrom
aayush_lessons_learned_hover_ghost_bar_graph

Conversation

@aayushshetty12
Copy link
Copy Markdown
Contributor

Description

Screenshot 2025-11-27 024521

Related PRS (if any):

#3619

Main changes explained:

  • Updated InjuryCategoryBarChart.jsx

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to /bmdashboard/totalconstructionsummary
  6. go to Lessons Learned > Injury Severity by Category of Worker Injured
  7. no graph should be shown if no data available

Screenshots or videos of changes:

Recording.2025-11-26.234413.mp4

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 27, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit be569ba
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/696ab3b1be01570008a1f5b3
😎 Deploy Preview https://deploy-preview-4461--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

VijayAnirudh
VijayAnirudh previously approved these changes Nov 29, 2025
Copy link
Copy Markdown

@VijayAnirudh VijayAnirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image ### Review Summary ✅

Tested the aayush_lessons_learned_hover_ghost_bar_graph branch locally:

  • Graph Rendering

    • Verified that when chartData is empty, the bar chart no longer renders a ghost/empty graph.
    • When valid data exists, the chart displays correctly with proper alignment and labels.
  • Error & Loading States

    • Confirmed that Loading… and Error messages display appropriately.
    • No console warnings or runtime errors observed.
  • Code Quality

    • ESLint warning resolved in Header.jsx (unused variable removed).
    • Minor cleanup in yarn.lock applied without breaking dependencies.
  • Deploy Preview

    • Netlify preview matches local behavior — ghost graph issue is resolved and UI remains consistent.

Conclusion

All acceptance criteria have been met:

  • Ghost graph no longer appears when no data is available.
  • Graph renders correctly when data exists.
  • Code cleanup and ESLint fixes applied.

Approving this PR ✅

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Dec 29, 2025
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Aayush,

I have reviewed your PR locally, though when selecting date's the chart does not render a ghost graph but when the date filter is not selected, we can see ghost bar graph. Assuming this is an acceptable scenario, there is also space left for the graph in terms of no ghost graphs, so i am requesting changes in the PR.
Screenshot 2026-01-02 at 2 07 46 AM
Screenshot 2026-01-02 at 2 09 36 AM

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Aayush,

Thanks for updating the PR, no more ghost bar is visible.
Screenshot 2026-01-24 at 1 38 48 AM
Screenshot 2026-01-24 at 1 39 30 AM
Screenshot 2026-01-24 at 1 39 41 AM
Screenshot 2026-01-24 at 1 39 46 AM
Screenshot 2026-01-24 at 1 39 56 AM
Screenshot 2026-01-24 at 1 40 07 AM

Copy link
Copy Markdown
Contributor

@naiduajaykumar naiduajaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everthing look fine approving this pr.
Screenshot 2026-02-05 162718
Screenshot 2026-02-05 162737

Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Aayush,

Well done with this implementation.

Image Image

Copy link
Copy Markdown
Contributor

@saitejakaasoju saitejakaasoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Aayush,
I tested this PR locally following the “How to test” steps. In Lessons Learned -> Injury Severity by Category of Worker Injured, the graph renders when data is available (e.g., with default/no specific filters), and when there is no data the page shows “No data for selected filters”, no graph/hover ghost bar is displayed. Looks good to merge.

Image Image Image

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 7d34c7d into development Apr 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants