Skip to content

sumedh - bugfix: fixes equipment checkin and checkout in daily activity log page#4462

Merged
one-community merged 6 commits intodevelopmentfrom
sumedh-bugfix-tool-equipment-daily-activity-log
Jan 23, 2026
Merged

sumedh - bugfix: fixes equipment checkin and checkout in daily activity log page#4462
one-community merged 6 commits intodevelopmentfrom
sumedh-bugfix-tool-equipment-daily-activity-log

Conversation

@sumedhkumar96
Copy link
Copy Markdown
Contributor

@sumedhkumar96 sumedhkumar96 commented Nov 27, 2025

Description

image

Issues:

Tools and Equipment Daily Activity Log Bug

Main changes explained:

  • Modified the EDailyActivityLog.jsx with safety checks and added consistent dark mode.

How to test:

  1. Check into the current branch
  2. Do npm install and npm run start:local to run this PR locally
  3. Clear site data/cache
  4. Log in as Owner user
  5. Go to /bmdashboard/T/EDailyActivityLog
  6. Login again with the same username and password
  7. Select a suitable Project.
  8. Add equipment and check them in and out.

Screenshots or videos of changes:

PR-4462.mp4

Note:

None

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 27, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 4354e48
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6973f89dd1b4670008465015
😎 Deploy Preview https://deploy-preview-4462--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

@sumedhkumar96 sumedhkumar96 added High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible and removed Medium Priority labels Jan 4, 2026
@sumedhkumar96 sumedhkumar96 changed the title sumedh-bugfix: fixes equipment checkin and checkout in daily activity log page sumedh - bugfix: fixes equipment checkin and checkout in daily activity log page Jan 4, 2026
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sumedh,

I have reviewed your PR locally and though the functionality does work as expected. I just have a question: an equipment checked in yesterday could be checkout today or any future date, but since the calendar does not block previous date entry - i can clockout the equipment at any date. Similarly for check-in, i can check it in any time in the past dates. Wouldn't this irregularity be an issue.

4462.mp4

Note: Also the calendar in dark mode appears in white backgrounf

Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sumedh,

Good job with this. A couple issues, I can select past dates for checkin and out. Also calendar is on white background.

PR 4462 Screenshot Pr 4462 Screenshot 2

@sumedhkumar96
Copy link
Copy Markdown
Contributor Author

@Anusha-Gali @rohanrastogi311 thanks for your comments. I have addressed those in my last commit, please do check it out

Anusha-Gali
Anusha-Gali previously approved these changes Jan 22, 2026
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sumedh,

Thanks for making the updates. I have re-reviewed your PR locally and the issue mentioned appear to be fixed.
Screenshot 2026-01-22 at 12 18 21 PM
Screenshot 2026-01-22 at 12 19 01 PM
Screenshot 2026-01-22 at 12 20 49 PM

@sonarqubecloud
Copy link
Copy Markdown

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit e29c115 into development Jan 23, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants