Skip to content

Neeraj Fix Job Posting Analytics Frontend#4463

Merged
one-community merged 3 commits intodevelopmentfrom
Neeraj_Fix_Job_Posting_Analytics_Frontend
Dec 2, 2025
Merged

Neeraj Fix Job Posting Analytics Frontend#4463
one-community merged 3 commits intodevelopmentfrom
Neeraj_Fix_Job_Posting_Analytics_Frontend

Conversation

@Neeraj-Kondaveeti
Copy link
Copy Markdown
Contributor

@Neeraj-Kondaveeti Neeraj-Kondaveeti commented Nov 27, 2025

Description

image image

Related PRS (if any):

This frontend PR is related to the development backend PR.
To test this backend PR you need to checkout the development backend PR.

Main changes explained:

  • Fixed Filter Alignment & Layout Consistency
  • Improved Graph Alignment & Prevented Label Overflow
  • Fixed Y-Axis Job Role Truncation / Overlap
  • Enhanced Dark Mode Accessibility
  • Added PropTypes validation for all incoming props (title, hits, applications, conversionRate, etc.).
  • Updated ResizeObserver mock to include non-empty methods to eliminate SonarQube "empty method" issues.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. Navigate to : http://localhost:5173/job-analytics
  6. Verify the following :
  • Filter Alignment
    • Date range dropdown + “Show %” checkbox + “Loading analytics…” have been provided with padding so that they are not hugging the extreme left side of the page.
  • Converted Applications Graph and Non-Converted Applications Graph:
    • Bars fully visible inside container.
    • Labels do not overflow.
    • Tooltip is readable in dark mode (white text, not blue).
  • Dark Mode
    - All labels, ticks, axes, and tooltip text remain fully readable.

Screenshots or videos of changes:

image image

Note:

  • This PR also introduces new test files for the analytics graphs to ensure future maintainability and consistent coverage of sorting, rendering, and dark-mode behaviors.
  • A ResizeObserver mock was added and improved inside setupTests.js to prevent test environment crashes.

@Neeraj-Kondaveeti Neeraj-Kondaveeti added the do not review Do not review or look at code without full context label Nov 27, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 27, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit aab02e7
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6928bf2f7c00960008630a44
😎 Deploy Preview https://deploy-preview-4463--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Neeraj-Kondaveeti Neeraj-Kondaveeti changed the title Neeraj fix job posting analytics frontend Neeraj_Fix_Job_Posting_Analytics_Frontend Nov 27, 2025
@sonarqubecloud
Copy link
Copy Markdown

@Neeraj-Kondaveeti Neeraj-Kondaveeti added Medium Priority and removed do not review Do not review or look at code without full context labels Nov 27, 2025
@VijayAnirudh VijayAnirudh self-assigned this Nov 28, 2025
@VijayAnirudh
Copy link
Copy Markdown

GithubPR4463-Cmnt

Review Summary ✅

I pulled down the Neeraj_Fix_Job_Posting_Analytics_Frontend branch and tested it locally against the backend development branch. Here are the results of my verification:

  • Filter Alignment & Layout Consistency
    • Date range dropdown, “Show %” checkbox, and “Loading analytics…” message now have proper padding and are no longer hugging the left edge.
  • Graph Alignment & Label Handling
    • Converted and Non-Converted Applications graphs render fully within the container.
    • Y-axis job role labels are no longer truncated or overlapping.
    • Graph labels do not overflow outside their containers.
  • Dark Mode Accessibility
    • Tooltip text is clearly readable in dark mode (white text instead of blue).
    • All labels, ticks, and axes remain legible in both light and dark themes.
  • PropTypes Validation
    • Verified that incoming props (title, hits, applications, conversionRate, etc.) are validated correctly with no warnings in console.
  • Testing & Maintainability
    • New test files for analytics graphs run successfully and cover sorting, rendering, and dark-mode behaviors.
    • Updated ResizeObserver mock resolves SonarQube “empty method” issues and prevents test environment crashes.
  • Deployment Preview
    • Netlify deploy preview matches local behavior and confirms fixes are consistent in hosted environment.

Conclusion

All acceptance criteria have been met:

  • UI fixes are working as expected.
  • Dark mode accessibility is solid.
  • Tests pass with no regressions.
  • SonarQube Quality Gate passed.

Approving this PR

@VijayAnirudh VijayAnirudh removed their assignment Nov 28, 2025
Copy link
Copy Markdown

@IndraAnuraag9 IndraAnuraag9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR locally using an Admin account. Everything is working as intended. Filter Alignment, Graph Alignment and Data Labels are properly contained without any overflow. Y-Axis Labels are no longer overlapping. No issues with visibility of labels in Dark Mode.

Screenshot 2025-11-27 at 11 22 08 PM Screenshot 2025-11-27 at 11 22 45 PM

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Neeraj,

I have reviewed your PR locally and all the requirement have been satisfied.
Screenshot 2025-11-28 at 8 14 09 PM
Screenshot 2025-11-28 at 8 14 17 PM

@Prem203
Copy link
Copy Markdown
Contributor

Prem203 commented Nov 30, 2025

Reviewed the PR with an admin account and the job analytics page does not seem to load any data. The console shows that no the api responded with 404 not found error. Let me know if I am doing anything wrong and I can check the PR again.

image

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 43e9671 into development Dec 2, 2025
10 checks passed
@Neeraj-Kondaveeti Neeraj-Kondaveeti changed the title Neeraj_Fix_Job_Posting_Analytics_Frontend Neeraj Fix Job Posting Analytics Frontend Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants