Skip to content

Peterson fixed the filter not finding users due to inner spaces. #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterson337 wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Peterson fixed the filter not finding users due to inner spaces. #4464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/UserManagement/UserManagement.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,9 +336,9 @@
let lastNameMatches = true;
if (trimmedLastNameSearch) {
if (isLastNameExactMatch) {
lastNameMatches = lastName === trimmedLastNameSearch.toLowerCase();
lastNameMatches = lastName === trimmedLastNameSearch.toLowerCase().replace(/\s+/g, '').trim();

Check warning on line 339 in src/components/UserManagement/UserManagement.jsx

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 


See more on https://sonarcloud.io/project/issues?id=OneCommunityGlobal_HighestGoodNetworkApp&issues=AZrHfjrdcONpQyvoc4QO&open=AZrHfjrdcONpQyvoc4QO&pullRequest=4464
} else {
lastNameMatches = lastName.includes(trimmedLastNameSearch.toLowerCase());
lastNameMatches = lastName.includes(trimmedLastNameSearch.toLowerCase().replace(/\s+/g, '').trim());

Check warning on line 341 in src/components/UserManagement/UserManagement.jsx

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 


See more on https://sonarcloud.io/project/issues?id=OneCommunityGlobal_HighestGoodNetworkApp&issues=AZrHfjrdcONpQyvoc4QP&open=AZrHfjrdcONpQyvoc4QP&pullRequest=4464
}
}

Expand Down
Loading