sumedh - bugfix: fixes global distribution map#4473
sumedh - bugfix: fixes global distribution map#4473one-community merged 7 commits intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sumedhkumar96
added
the
High Priority - Please Review First
sundarmachani
left a comment
sundarmachani
left a comment
There was a problem hiding this comment.
Reviewed this PR, and the code changes are working great. I noticed that this also fixes the data filter functionality, which wasn’t working before. Great job on that! Also, the dark mode looks good with the highlighted button.
Before:
After:
Prem203
left a comment
Prem203
left a comment
There was a problem hiding this comment.
Reviewed the PR with and owner account and the global distribution map now renders correct number of projects. The same is now reflected in dark mode as well.
|
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Sumedh,
I have reviewed your PR locally and all the functionalites do work as per the requirement, though i have identified one issue which could be out of scope - when we filter dates which are not related to any projects, all the projects are still visible - even if we assume that they could be active - you can see below the projects with status completed is visible.
Issue identified
Note: Approving your PR since the issue is not a part of your requirement but do let the team managing the document know that this issue exists
|
@Anusha-Gali can you please provide an example of the dates? I will see if that can be fixed. |
rohanrastogi311
left a comment
rohanrastogi311
left a comment
There was a problem hiding this comment.
All functionality has been tested, working well. Good Job.
sumedhkumar96
changed the title
Hi Sumedh, Below video shows you two different scenarios. The first being me selecting a timeframe before the start of Test Project Alpha, still i can see that project. I have attached screenshot for Test Project Beta too wherein i have selected start date way before the project's but still all are visible even the one's that started in 2025. The second scenario if i selected the same start and end data still all project's are visible. Attached screenshot for Test Project Beta too. sumedh.mov
|
…based on lat and long
|
@Anusha-Gali thanks for sharing a detailed info the date filtering issue. Apparently the project have End Date along with the Start Date and it was not displayed in the UI, so it looked like it was filtering out the wrong data. I have verified the date filter logic and also have made changes to the UI to display both start and end dates of the projects. Now the date filters display all the projects that fall within the date range i.e., it could have start date or end date or both in the given range. Also you might see the UI has changed a bit, that is because somebody else had worked on the same code changed the appearance a bit. I have attached a screen recording below for your reference. Thanks! GlobalDistributionMap.mp4 |
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Sumedh,
Appreciate your update. I have re-reviewed your PR locally and it works as expected.
|
This feature worked as intended and the code is great 
|
sumedhkumar96
dismissed stale reviews from beblicarl and Anusha-Gali
via
0d60477
|
|
Thank you all, merging! |
7 participants
Description
Issues:
Global distribution map issue
Main changes explained:
How to test:
npm installandnpm run start:localto run this PR locallyScreenshots or videos of changes:
GlobalDistributionMap.mp4
Note:
None