Skip to content

Prem-Fixed past date selection in activity list#4480

Open
Prem203 wants to merge 2 commits intodevelopmentfrom
Prem-past-date-allowed-activity-list
Open

Prem-Fixed past date selection in activity list#4480
Prem203 wants to merge 2 commits intodevelopmentfrom
Prem-past-date-allowed-activity-list

Conversation

@Prem203
Copy link
Copy Markdown
Contributor

@Prem203 Prem203 commented Nov 30, 2025

Description

image image

Related PRS (if any):

This frontend PR is not related to any backend PR.

Main changes explained:

  • Update file ActivityList.jsx and its css module to add past date validation and support for dark mode.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to /communityportal/activities
  6. verify that the date picker does not allow past dates to be selected.
  7. verify this new feature works in dark mode.

Screenshots or videos of changes:

image image

Note:

N/A

@Prem203 Prem203 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Nov 30, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 30, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 68fc10f
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6935cfda2a15b60008e1ae1f
😎 Deploy Preview https://deploy-preview-4480--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Prem,

I have reviewed your PR locally, the main functionality of the calendar not showing past date works as per requirement. Issue 1: Though in dark mode When navigating to a date with no activities - it looks as below i.e a full-width block appears across the entire page.
Screenshot 2025-12-05 at 4 43 37 PM
Screenshot 2025-12-05 at 4 44 33 PM
Issue 2: When selecting the current date (which also has no events), the layout does not appear centered relative to the calendar. Additionally, past events are still being displayed in this view.
Screenshot 2025-12-05 at 4 48 37 PM
Screenshot 2025-12-05 at 4 51 30 PM
Main functionality - works as per requirement
Screenshot 2025-12-05 at 4 40 01 PM
Screenshot 2025-12-05 at 4 40 08 PM

Note: let me know if any of this is not a part of your requirement.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 7, 2025

Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall functionality works, unable to select past dates. Issue: In dark mode there is a bar spanning the entire screen where the date selector is. It's not showing in light mode though.
PR 4480 Screenshot
PR 4480 Screenshot 2

@one-community one-community added Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. do not review Do not review or look at code without full context and removed High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible labels Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not review Do not review or look at code without full context Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants