Linh – Fix Educator Task Submissions UI + Late Submission Detection Improvements#4486
Open
linh2020 wants to merge 3 commits intodevelopmentfrom
Open
Linh – Fix Educator Task Submissions UI + Late Submission Detection Improvements#4486linh2020 wants to merge 3 commits intodevelopmentfrom
linh2020 wants to merge 3 commits intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
linh2020
changed the title
one-community
added
the
High Priority - Please Review First
Anusha-Gali
suggested changes
Dec 24, 2025
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Linh,
I have reviewed your PR locally and as you can see in the below video, the huge unnecessary data i.e neither graded or pending review is causing lag and is breaking the mobile responsiveness.
4486.mp4
…nsiveness - Suppress 'Failed to fetch sub-tasks' toast on 404 (demo/mock task IDs that don't exist in the DB no longer flood the UI with error toasts) - Add Active / Pending Review / Completed filter tabs so graded and completed tasks are hidden by default, eliminating unnecessary renders - Lazy-load intermediate tasks only for the currently visible (filtered) tasks; cache results to avoid redundant API calls on tab switch - Replace overflow nav bar with a hamburger menu on mobile (≤768px) - Fix card grid min-width and single-column collapse on mobile - Remove fixed min-height from TaskCard; fix action-button layout at small breakpoints (480px) for both card and list views
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the backend and frontend issues preventing the Educator Task Submissions page from working correctly and completes missing logic requested by Harshitha & Sphurthy.
The previous PR (#4207 frontend, #1799 backend) implemented the UI but failed to load or filter student submissions due to missing studentId and incorrect filtering logic.
This PR resolves those issues and adds improved functionality.
Related PRS (if any):
This frontend PR is related to the backend PR#1934
Main changes explained:
"All Submissions" → returns all
"Pending Review" → only pending
"Graded" → only graded
Before: always returned full list
After: correct filtering based on backend data
lessonPlanId → classes
taskName → task groups inside each class
TaskSubmissionsPage
SubmissionCard
Tabs, dropdown, tooltips, card states
How to test:
npm installand...to run this PR locallyLogin with an educator account
Navigate to /educationportal/educator/task-submissions
Verify the page loads with submission data
Verify:
Tabs load class names
Tasks expand correctly
Cards show:
pending → info tooltip
graded → badge
late → red styling
Filtering toggles results properly
No more infinite loading or 404/401 issues
Screenshots or videos of changes:
Note:
Include the information the reviewers need to know.