Skip to content

Peterson implemented a ‘no anniversary found’ message in the anniversary table. #4488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterson337 wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Peterson implemented a ‘no anniversary found’ message in the anniversary table. #4488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/components/TotalOrgSummary/AnniversaryCelebrated/AnniversaryCelebrated.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,14 @@
const filterUsers = users =>
users.filter(u => `${u.firstName} ${u.lastName}`.toLowerCase().includes(search.toLowerCase()));

const usersFilteredSixMonthsData = filterUsers(sixMonthsData.users).map(item =>

Check warning on line 113 in src/components/TotalOrgSummary/AnniversaryCelebrated/AnniversaryCelebrated.jsx

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'data.6Months.users' is missing in props validation 


See more on https://sonarcloud.io/project/issues?id=OneCommunityGlobal_HighestGoodNetworkApp&issues=AZrmqvvMi1-4a2sx6r2b&open=AZrmqvvMi1-4a2sx6r2b&pullRequest=4488
getAnniversaryListItem(item, 6),
);

const usersFilteredOneYearData = filterUsers(oneYearData.users).map(item =>

Check warning on line 117 in src/components/TotalOrgSummary/AnniversaryCelebrated/AnniversaryCelebrated.jsx

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'data.1Year.users' is missing in props validation 


See more on https://sonarcloud.io/project/issues?id=OneCommunityGlobal_HighestGoodNetworkApp&issues=AZrmqvvMi1-4a2sx6r2c&open=AZrmqvvMi1-4a2sx6r2c&pullRequest=4488
getAnniversaryListItem(item, 12),
);

return (
<div className="mt-3">
{/* Comparison percentages with counts */}
Expand Down Expand Up @@ -169,8 +177,16 @@

{/* List of anniversaries */}
<ul className="w-90 overflow-auto" style={{ maxHeight: '410px' }}>
{filterUsers(sixMonthsData.users).map(item => getAnniversaryListItem(item, 6))}
{filterUsers(oneYearData.users).map(item => getAnniversaryListItem(item, 12))}
{usersFilteredSixMonthsData.length === 0 && usersFilteredOneYearData.length === 0 ? (
<p className="text-center" style={{ color: darkMode ? '#fff' : '#000' }}>
No anniversaries found
</p>
) : (
<>
{usersFilteredSixMonthsData}
{usersFilteredOneYearData}
</>
)}
</ul>
</div>
);
Expand Down
Loading