Skip to content

Neeraj Fix Dark Mode Filter Text Most Popular Event#4490

Merged
one-community merged 5 commits intodevelopmentfrom
Neeraj_Fix_DarkMode_FilterText_MostPopularEvent
Mar 25, 2026
Merged

Neeraj Fix Dark Mode Filter Text Most Popular Event#4490
one-community merged 5 commits intodevelopmentfrom
Neeraj_Fix_DarkMode_FilterText_MostPopularEvent

Conversation

@Neeraj-Kondaveeti
Copy link
Copy Markdown
Contributor

@Neeraj-Kondaveeti Neeraj-Kondaveeti commented Dec 4, 2025 •
edited
Loading

Description

image

Related PRS (if any):

To test this frontend PR you need to checkout the development backend.
…

Main changes explained:

  • Renamed EventStats.css → EventStats.module.css to align with the project's CSS Module standard and ensure proper dark mode scoping.
  • Updated EventStats.jsx (PopularEvents component) to fully implement dark mode text visibility for:
    • Time filter dropdown
    • Type filter dropdown
    • Component container background
  • Created new test file:
    • src/components/CommunityPortal/EventPersonalization/tests/EventStats.test.jsx
  • Added coverage for:
    • Rendering and filtering behavior
    • Dark mode style application
    • Summary card accuracy
      …

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. Navigate to : http://localhost:5173/communityportal/reports/event/personalization
  6. "Time of Day" and "Event Type" dropdowns display readable text in both light & dark mode. Text color switches correctly in dark mode based on the design guidelines.

Screenshots or videos of changes:

image image

Note:

The component now fully follows the Dark Mode Implementation Guide.

@Neeraj-Kondaveeti Neeraj-Kondaveeti added the do not review Do not review or look at code without full context label Dec 4, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 4, 2025 •
edited
Loading

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 37b7cb9
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69c092f997d19f0008addd1e
😎 Deploy Preview https://deploy-preview-4490--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Neeraj-Kondaveeti Neeraj-Kondaveeti changed the title Neeraj fix dark mode filter text most popular event Neeraj Fix Dark Mode Filter Text Most Popular Event Dec 4, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Neeraj-Kondaveeti Neeraj-Kondaveeti added High Priority and removed do not review Do not review or look at code without full context labels Dec 4, 2025
Prem203
Prem203 approved these changes Dec 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Prem203 Prem203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the PR with an admin account and the dropdowns render correctly in both light and dark modes.

image image image

@beblicarl
Copy link
Copy Markdown
Contributor

beblicarl commented Jan 15, 2026

This feature works as intended and the code is great

image image

@beblicarl beblicarl self-requested a review January 15, 2026 10:46
beblicarl
beblicarl previously approved these changes Jan 15, 2026
View reviewed changes
rohanrastogi311
rohanrastogi311 previously approved these changes Feb 28, 2026
View reviewed changes
Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Neeraj,

Well done with this implementation.

Image Image

@one-community one-community added High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible and removed High Priority labels Mar 21, 2026
@Neeraj-Kondaveeti Neeraj-Kondaveeti force-pushed the Neeraj_Fix_DarkMode_FilterText_MostPopularEvent branch from 9c3b230 to 37b7cb9 Compare March 23, 2026 01:10
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 23, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@one-community
Copy link
Copy Markdown
Member

one-community commented Mar 25, 2026

Thank you all, merging!

@one-community one-community merged commit 98fa51e into development Mar 25, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beblicarl beblicarl beblicarl left review comments

+2 more reviewers

@Prem203 Prem203 Prem203 approved these changes

@rohanrastogi311 rohanrastogi311 rohanrastogi311 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Neeraj-Kondaveeti @beblicarl @one-community @Prem203 @rohanrastogi311