Skip to content

Deep fix redundant tag insertion#4507

Merged
one-community merged 2 commits intodevelopmentfrom
deep-fix-redundant-tag-insertion
Dec 9, 2025
Merged

Deep fix redundant tag insertion#4507
one-community merged 2 commits intodevelopmentfrom
deep-fix-redundant-tag-insertion

Conversation

@deep3072
Copy link
Copy Markdown
Contributor

@deep3072 deep3072 commented Dec 5, 2025

Description

Screenshot 2025-12-05 at 14 19 13

Fixes

Selecting a project in “Belongs to” was automatically inserting that project as a tag, causing redundant tags. Updated lesson form so project selection only sets relatedProject and tags remain user-entered. No backend change required.

Related PRS (if any):

None

Main changes explained:

  • Update src/components/BMDashboard/Lesson/LessonForm.jsx to remove the effect/state that synced the selected project into tags.
  • Start tags state empty instead of seeding defaults so only user-added tags are kept.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as owner user
  5. go to http://localhost:5173/bmdashboard/lessonform
  6. Verify if when selecting the "Belongs to" project from the dropdown, does not add a tag in the tags list.

Screenshots or videos of changes:

Before:

Screen.Recording.2025-12-05.at.14.23.32.mov

After:

Screen.Recording.2025-12-05.at.14.24.36.mov

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 5, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 34089fc
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69335c271f51610007da3a5e
😎 Deploy Preview https://deploy-preview-4507--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

@Prem203 Prem203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the PR with an owner account. On selecting the building from dropdown, the tag is not added for the same. The tag can be added separately without any correlation.

image image

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 7e7e4f0 into development Dec 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants