Skip to content

Deep fix redundant tag insertion #4507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
one-community merged 2 commits into from
Dec 9, 2025
Merged

Deep fix redundant tag insertion #4507

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a1fc97
deep fix redundant tag insertion
deep3072 Dec 5, 2025
34089fc
Merge branch 'development' into deep-fix-redundant-tag-insertion
deep3072 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 2 additions & 38 deletions src/components/BMDashboard/Lesson/LessonForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,10 @@ function LessonForm() {
const roles = useSelector(state => state.role.roles); // grab all roles from store
// const projects = useSelector(state => state.allProjects.projects); // grab all projects from store(not BM projects)
const projects = useSelector(state => state.bmProjects); // grab all BM projects from store
const [LessonFormtags, setLessonFormTags] = useState(['Building 1', 'Building 2', 'Building 3']); // save all tags user inputs
const [permanentTags, setPermanentTags] = useState(['Building 1', 'Building 2', 'Building 3']);
const [LessonFormtags, setLessonFormTags] = useState([]); // save all tags user inputs
const [permanentTags, setPermanentTags] = useState([]);
const [tagInput, setTagInput] = useState(''); // track user input in tag input
const [selectedFile, setSelectedFile] = useState(null); // track file that was selected or droped in upload appendix
const [prevselectedProject, setprevSelectedProject] = useState(null); // used to track the previously project selected for deletion in tags when changed
const [selectedProject, setSelectedProject] = useState(null); // Track selected project in Belongs to dropdown
const [selectedRole, setSelectedRole] = useState('All'); // track selected role in View by dropdown
const [LessonText, setLessonText] = useState(null); // track lesson text
Expand Down Expand Up @@ -89,12 +88,6 @@ function LessonForm() {
const newTags = LessonFormtags.filter(tag => tag !== tagToRemove);
setLessonFormTags(newTags);
};
// removes the previously added project from tags if a new one is selected from belongs to dropdown
const removePreviousProject = prevproject => {
const newTags = LessonFormtags.filter(project => project !== prevproject);
setLessonFormTags(newTags);
};

const fetchTags = async () => {
try {
const response = await axios.get(ENDPOINTS.BM_TAGS);
Expand Down Expand Up @@ -137,7 +130,6 @@ function LessonForm() {
// Set the project name as a tag
setProjectName(foundProject.name);
setSelectedProject(projectId);
setLessonFormTags([projectname]);
}
}
}, [projectId, projects]);
Expand Down Expand Up @@ -193,38 +185,10 @@ function LessonForm() {
const lessonformtitleinput = e.target.value;
setLessonTitleText(lessonformtitleinput);
};
useEffect(() => {
if (selectedProject && prevselectedProject !== selectedProject) {
// Find the project with the selected ID
const foundProject = projects.find(project => project._id === selectedProject);
// Check if the found project is valid
if (foundProject) {
setprevSelectedProject(selectedProject);
// Remove the tag for the previously selected project
if (prevselectedProject) {
removePreviousProject(
projects.find(project => project._id === prevselectedProject)?.name,
);
}
// Add the project name to the tags array
setLessonFormTags(tags => [...tags, foundProject.name]);
}
}
}, [selectedProject, prevselectedProject, projects]);

// Lesson submit. all the data from user input is in here
const LessonFormSubmit = async e => {
e.preventDefault();
// console.log(LessonFormtags, "Tags")
// console.log(selectedProject, "selected project")
// console.log(selectedRole, "selecedRole")
// console.log(selectedFile, "selected file")
// console.log(LessonText, "lesson text")
// console.log(LessonTitleText,"lesson title")
if (!LessonFormtags.length) {
toast.info('Need atleast one tag');
return;
}
if (!selectedProject) {
toast.info('Need to select a project');
return;
Expand Down
Loading